[libcamera-devel,v5,1/4] ipa: ipu3: Extend ipu3 ipa interface for lens controls
diff mbox series

Message ID 20211126112903.3276056-2-hanlinchen@chromium.org
State Accepted
Headers show
Series
  • Introduce Lens class and apply auto focus on ipu3
Related show

Commit Message

Hanlin Chen Nov. 26, 2021, 11:29 a.m. UTC
IPU3Event and IPU3Action use two fields for both libcamera controls and sensor
V4L2 controls. The patch extend one more field for lens V4L2 controls
for auto focus usage.

Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 include/libcamera/ipa/ipu3.mojom | 2 ++
 1 file changed, 2 insertions(+)

Comments

Laurent Pinchart Nov. 30, 2021, 3:52 a.m. UTC | #1
Hi Han-lin,

Thank you for the patch.

On Fri, Nov 26, 2021 at 07:29:00PM +0800, Han-Lin Chen wrote:
> IPU3Event and IPU3Action use two fields for both libcamera controls and sensor
> V4L2 controls. The patch extend one more field for lens V4L2 controls
> for auto focus usage.
> 
> Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  include/libcamera/ipa/ipu3.mojom | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom
> index 16e3462e..cc0d822f 100644
> --- a/include/libcamera/ipa/ipu3.mojom
> +++ b/include/libcamera/ipa/ipu3.mojom
> @@ -24,12 +24,14 @@ struct IPU3Event {
>  	uint32 bufferId;
>  	libcamera.ControlList controls;
>  	libcamera.ControlList sensorControls;
> +	libcamera.ControlList lensControls;
>  };
>  
>  struct IPU3Action {
>  	IPU3Operations op;
>  	libcamera.ControlList controls;
>  	libcamera.ControlList sensorControls;
> +	libcamera.ControlList lensControls;
>  };
>  
>  struct IPAConfigInfo {

Patch
diff mbox series

diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom
index 16e3462e..cc0d822f 100644
--- a/include/libcamera/ipa/ipu3.mojom
+++ b/include/libcamera/ipa/ipu3.mojom
@@ -24,12 +24,14 @@  struct IPU3Event {
 	uint32 bufferId;
 	libcamera.ControlList controls;
 	libcamera.ControlList sensorControls;
+	libcamera.ControlList lensControls;
 };
 
 struct IPU3Action {
 	IPU3Operations op;
 	libcamera.ControlList controls;
 	libcamera.ControlList sensorControls;
+	libcamera.ControlList lensControls;
 };
 
 struct IPAConfigInfo {