[libcamera-devel,v3,3/4] pipeline: raspberrypi: Increase the V4L2BufferCache slot allocations
diff mbox series

Message ID 20211118164216.2669449-4-naush@raspberrypi.com
State Accepted
Commit 9c246b77e4982d4fbfdbf980df0d374547d7bfcc
Headers show
Series
  • raspberrypi: Rework the internal buffer allocation scheme
Related show

Commit Message

Naushir Patuck Nov. 18, 2021, 4:42 p.m. UTC 
If a stream is marked as external, double the number of V4L2BufferCache slots
that are allocated. This is to account for additional buffers that may be
allocated directly by the application.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 11 +++++++++++
 1 file changed, 11 insertions(+)

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
index b3265d0e8aab..bab80d25ad1a 100644
--- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
+++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
@@ -107,6 +107,17 @@  int Stream::prepareBuffers(unsigned int count)
 		count = bufferMap_.size();
 	}
 
+	/*
+	 * If this is an external stream, we must allocate slots for buffers that
+	 * might be externally allocated. We have no indication of how many buffers
+	 * may be used, so this might overallocate slots in the buffer cache.
+	 *
+	 * \todo Find a better heuristic, or, even better, an exact solution to
+	 * this issue.
+	 */
+	if (isExternal())
+		count = count * 2;
+
 	return dev_->importBuffers(count);
 }