[libcamera-devel,14/22] ipa: ipu3: Introduce a queue of IPAFrameContext
diff mbox series

Message ID 20211108131350.130665-15-jeanmichel.hautbois@ideasonboard.com
State Superseded
Headers show
Series
  • IPA: IPU3: Introduce per-frame controls
Related show

Commit Message

Jean-Michel Hautbois Nov. 8, 2021, 1:13 p.m. UTC
In order to have multiple frame contexts, we will need a queue to store
those. Introduce it in IPAIPU3 but do not use it in this commit yet.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
---
 src/ipa/ipu3/ipu3.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Kieran Bingham Nov. 8, 2021, 3:42 p.m. UTC | #1
Quoting Jean-Michel Hautbois (2021-11-08 13:13:42)
> In order to have multiple frame contexts, we will need a queue to store
> those. Introduce it in IPAIPU3 but do not use it in this commit yet.
> 

I suspect this should likely be added where it gets used ... let's see
what the next patches bring...

> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
> ---
>  src/ipa/ipu3/ipu3.cpp | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index b4e0d49f..62df7819 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -11,6 +11,7 @@
>  #include <limits>
>  #include <map>
>  #include <memory>
> +#include <queue>
>  #include <stdint.h>
>  #include <utility>
>  #include <vector>
> @@ -180,7 +181,10 @@ private:
>         /* Maintain the algorithms used by the IPA */
>         std::list<std::unique_ptr<ipa::ipu3::Algorithm>> algorithms_;
>  
> -       /* Local parameter storage */
> +       /* Queue for storing the per-frame context */
> +       std::queue<IPAFrameContext *> frameContextQueue;
> +
> +       /* Local context storage */
>         struct IPAContext context_;
>  };
>  
> -- 
> 2.32.0
>

Patch
diff mbox series

diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
index b4e0d49f..62df7819 100644
--- a/src/ipa/ipu3/ipu3.cpp
+++ b/src/ipa/ipu3/ipu3.cpp
@@ -11,6 +11,7 @@ 
 #include <limits>
 #include <map>
 #include <memory>
+#include <queue>
 #include <stdint.h>
 #include <utility>
 #include <vector>
@@ -180,7 +181,10 @@  private:
 	/* Maintain the algorithms used by the IPA */
 	std::list<std::unique_ptr<ipa::ipu3::Algorithm>> algorithms_;
 
-	/* Local parameter storage */
+	/* Queue for storing the per-frame context */
+	std::queue<IPAFrameContext *> frameContextQueue;
+
+	/* Local context storage */
 	struct IPAContext context_;
 };