[libcamera-devel] android: camera_device: Cleanup header includes

14187 diff mbox series

camera_device.cpp doesn't use the PostProcessor class, the
post_processor.h header shouldn't be included. Removing it causes a
compilation failure as the CameraBuffer class is not defined anymore,
include camera_buffer.h instead.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/android/camera_device.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: a31c8f02b9965ebe5b7d4347e4316172e4b7e8d0

Hi Laurent,

Thank you for this patch

On 10/20/21 8:58 AM, Laurent Pinchart wrote:
> camera_device.cpp doesn't use the PostProcessor class, the
> post_processor.h header shouldn't be included. Removing it causes a
> compilation failure as the CameraBuffer class is not defined anymore,
> include camera_buffer.h instead.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


I was carrying this change in my post-processor-async branch so,

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   src/android/camera_device.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index ea676409b474..806b40908e98 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -24,10 +24,10 @@
>   
>   #include "system/graphics.h"
>   
> +#include "camera_buffer.h"
>   #include "camera_hal_config.h"
>   #include "camera_ops.h"
>   #include "camera_request.h"
> -#include "post_processor.h"
>   
>   using namespace libcamera;
>   
>
> base-commit: a31c8f02b9965ebe5b7d4347e4316172e4b7e8d0

HI Laurent, thank you for the patch.

On Wed, Oct 20, 2021 at 12:53 PM Umang Jain <umang.jain@ideasonboard.com> wrote:
>
> Hi Laurent,
>
> Thank you for this patch
>
> On 10/20/21 8:58 AM, Laurent Pinchart wrote:
> > camera_device.cpp doesn't use the PostProcessor class, the
> > post_processor.h header shouldn't be included. Removing it causes a
> > compilation failure as the CameraBuffer class is not defined anymore,
> > include camera_buffer.h instead.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
>
> I was carrying this change in my post-processor-async branch so,
>
> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
>

Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

> > ---
> >   src/android/camera_device.cpp | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> > index ea676409b474..806b40908e98 100644
> > --- a/src/android/camera_device.cpp
> > +++ b/src/android/camera_device.cpp
> > @@ -24,10 +24,10 @@
> >
> >   #include "system/graphics.h"
> >
> > +#include "camera_buffer.h"
> >   #include "camera_hal_config.h"
> >   #include "camera_ops.h"
> >   #include "camera_request.h"
> > -#include "post_processor.h"
> >
> >   using namespace libcamera;
> >
> >
> > base-commit: a31c8f02b9965ebe5b7d4347e4316172e4b7e8d0