[libcamera-devel,v2,4/7] test: ipa_data_serializer: Remove controls::AeEnable
diff mbox series

Message ID 20211001103325.1077590-5-paul.elder@ideasonboard.com
State New
Headers show
Series
  • The Great AE Changes
Related show

Commit Message

Paul Elder Oct. 1, 2021, 10:33 a.m. UTC
Remove controls::AeEnable from the IPA data serializer test, as it is no
longer an available control.

Bug: https://bugs.libcamera.org/show_bug.cgi?id=42
Bug: https://bugs.libcamera.org/show_bug.cgi?id=43
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>

---
No change in v2
---
 test/serialization/ipa_data_serializer_test.cpp | 1 -
 1 file changed, 1 deletion(-)

Comments

Kieran Bingham Oct. 29, 2021, 8:29 a.m. UTC | #1
Quoting Paul Elder (2021-10-01 11:33:22)
> Remove controls::AeEnable from the IPA data serializer test, as it is no
> longer an available control.

Has AeEnable been removed from the control declarations? If so, does
this need to be merged with it to prevent compilation failures?

Or otherwise, should it be removed? (In this patch?)


I've just grabbed your current development branch, and indeed there is
compilation breakage in "controls: Reorganize the AE-related controls"

so this needs to be handled in a way that will keep each commit
compiling to prevent bisection.

--
Kieran


> 
> Bug: https://bugs.libcamera.org/show_bug.cgi?id=42
> Bug: https://bugs.libcamera.org/show_bug.cgi?id=43
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> 
> ---
> No change in v2
> ---
>  test/serialization/ipa_data_serializer_test.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp
> index 5fcdcb8e..85ad4d04 100644
> --- a/test/serialization/ipa_data_serializer_test.cpp
> +++ b/test/serialization/ipa_data_serializer_test.cpp
> @@ -33,7 +33,6 @@ using namespace std;
>  using namespace libcamera;
>  
>  static const ControlInfoMap Controls = ControlInfoMap({
> -               { &controls::AeEnable, ControlInfo(false, true) },
>                 { &controls::ExposureTime, ControlInfo(0, 999999) },
>                 { &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },
>                 { &controls::ColourGains, ControlInfo(0.0f, 32.0f) },
> -- 
> 2.27.0
>

Patch
diff mbox series

diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp
index 5fcdcb8e..85ad4d04 100644
--- a/test/serialization/ipa_data_serializer_test.cpp
+++ b/test/serialization/ipa_data_serializer_test.cpp
@@ -33,7 +33,6 @@  using namespace std;
 using namespace libcamera;
 
 static const ControlInfoMap Controls = ControlInfoMap({
-		{ &controls::AeEnable, ControlInfo(false, true) },
 		{ &controls::ExposureTime, ControlInfo(0, 999999) },
 		{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },
 		{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },