[libcamera-devel,2/2] simple-cam: Use matching type to store stream size
diff mbox series

Message ID 20210926203319.18289-2-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-devel,1/2] simple-cam: Turn globals static
Related show

Commit Message

Laurent Pinchart Sept. 26, 2021, 8:33 p.m. UTC 
From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>

Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
---
 simple-cam.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart Sept. 26, 2021, 8:41 p.m. UTC | #1 
Hi Dorota,

Thank you for the patch.

On Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:
> From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>

We usually try to have a commit message body, even for simple patches.
This could be

The std::vector::size() function returns a size_t. Use the same type of
the variable that stores the return value to avoid a compiler warning.

I'll let Kieran apply the patches, I'm sure he can update the commit
message with the above text (if you're fine with it).

> Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> ---
>  simple-cam.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/simple-cam.cpp b/simple-cam.cpp
> index 350f68be7906..e374e45849dc 100644
> --- a/simple-cam.cpp
> +++ b/simple-cam.cpp
> @@ -299,7 +299,7 @@ int main()
>  			return EXIT_FAILURE;
>  		}
>  
> -		unsigned int allocated = allocator->buffers(cfg.stream()).size();
> +		size_t allocated = allocator->buffers(cfg.stream()).size();
>  		std::cout << "Allocated " << allocated << " buffers for stream" << std::endl;
>  	}
>
Kieran Bingham Sept. 27, 2021, 12:03 p.m. UTC | #2 
On Sun, Sep 26, 2021 at 11:41:58PM +0300, Laurent Pinchart wrote:
> Hi Dorota,
> 
> Thank you for the patch.
> 
> On Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:
> > From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> 
> We usually try to have a commit message body, even for simple patches.
> This could be
> 
> The std::vector::size() function returns a size_t. Use the same type of
> the variable that stores the return value to avoid a compiler warning.
> 
> I'll let Kieran apply the patches, I'm sure he can update the commit
> message with the above text (if you're fine with it).

Laurent: Will you be adding a tag?

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> > ---
> >  simple-cam.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/simple-cam.cpp b/simple-cam.cpp
> > index 350f68be7906..e374e45849dc 100644
> > --- a/simple-cam.cpp
> > +++ b/simple-cam.cpp
> > @@ -299,7 +299,7 @@ int main()
> >  			return EXIT_FAILURE;
> >  		}
> >  
> > -		unsigned int allocated = allocator->buffers(cfg.stream()).size();
> > +		size_t allocated = allocator->buffers(cfg.stream()).size();
> >  		std::cout << "Allocated " << allocated << " buffers for stream" << std::endl;
> >  	}
> >  
> 
> -- 
> Regards,
> 
> Laurent Pinchart
Laurent Pinchart Sept. 27, 2021, 3:49 p.m. UTC | #3 
Hi Kieran,

On Mon, Sep 27, 2021 at 01:03:10PM +0100, Kieran Bingham wrote:
> On Sun, Sep 26, 2021 at 11:41:58PM +0300, Laurent Pinchart wrote:
> > On Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:
> > > From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> > 
> > We usually try to have a commit message body, even for simple patches.
> > This could be
> > 
> > The std::vector::size() function returns a size_t. Use the same type of
> > the variable that stores the return value to avoid a compiler warning.
> > 
> > I'll let Kieran apply the patches, I'm sure he can update the commit
> > message with the above text (if you're fine with it).
> 
> Laurent: Will you be adding a tag?
> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Sure thing.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I expect you to push the recently submitted simple-cam patches, please
let me know if you need my help.

> > > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> > > ---
> > >  simple-cam.cpp | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/simple-cam.cpp b/simple-cam.cpp
> > > index 350f68be7906..e374e45849dc 100644
> > > --- a/simple-cam.cpp
> > > +++ b/simple-cam.cpp
> > > @@ -299,7 +299,7 @@ int main()
> > >  			return EXIT_FAILURE;
> > >  		}
> > >  
> > > -		unsigned int allocated = allocator->buffers(cfg.stream()).size();
> > > +		size_t allocated = allocator->buffers(cfg.stream()).size();
> > >  		std::cout << "Allocated " << allocated << " buffers for stream" << std::endl;
> > >  	}
> > >
Dorota Czaplejewicz Sept. 27, 2021, 3:54 p.m. UTC | #4 
Hi Laurent,

On Sun, 26 Sep 2021 23:41:58 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> Hi Dorota,
> 
> Thank you for the patch.
> 
> On Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:
> > From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>  
> 
> We usually try to have a commit message body, even for simple patches.

Sorry, I didn't realize that. I'm used to coming up with a sufficient explanation and then putting it in the first line if it fits.

> This could be
> 
> The std::vector::size() function returns a size_t. Use the same type of
> the variable that stores the return value to avoid a compiler warning.
> 
> I'll let Kieran apply the patches, I'm sure he can update the commit
> message with the above text (if you're fine with it).
> 
I don't mind at all, go ahead.

Cheers,
Dorota

> > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> > ---
> >  simple-cam.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/simple-cam.cpp b/simple-cam.cpp
> > index 350f68be7906..e374e45849dc 100644
> > --- a/simple-cam.cpp
> > +++ b/simple-cam.cpp
> > @@ -299,7 +299,7 @@ int main()
> >  			return EXIT_FAILURE;
> >  		}
> >  
> > -		unsigned int allocated = allocator->buffers(cfg.stream()).size();
> > +		size_t allocated = allocator->buffers(cfg.stream()).size();
> >  		std::cout << "Allocated " << allocated << " buffers for stream" << std::endl;
> >  	}
> >    
>
Kieran Bingham Sept. 27, 2021, 4:33 p.m. UTC | #5 
On Mon, Sep 27, 2021 at 06:49:21PM +0300, Laurent Pinchart wrote:
> Hi Kieran,
> 
> On Mon, Sep 27, 2021 at 01:03:10PM +0100, Kieran Bingham wrote:
> > On Sun, Sep 26, 2021 at 11:41:58PM +0300, Laurent Pinchart wrote:
> > > On Sun, Sep 26, 2021 at 11:33:19PM +0300, Laurent Pinchart wrote:
> > > > From: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> > > 
> > > We usually try to have a commit message body, even for simple patches.
> > > This could be
> > > 
> > > The std::vector::size() function returns a size_t. Use the same type of
> > > the variable that stores the return value to avoid a compiler warning.
> > > 
> > > I'll let Kieran apply the patches, I'm sure he can update the commit
> > > message with the above text (if you're fine with it).
> > 
> > Laurent: Will you be adding a tag?
> > 
> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> Sure thing.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks,

> 
> I expect you to push the recently submitted simple-cam patches, please
> let me know if you need my help.

That's fine, I'm planning to handle them. But I've had a day throwing
all my e-mail workflows out of the pram ;-)

But ... I hope it's all for the greater good, as now I can integrate
patchwork states into my mailbox ...


> > > > Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> > > > ---
> > > >  simple-cam.cpp | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/simple-cam.cpp b/simple-cam.cpp
> > > > index 350f68be7906..e374e45849dc 100644
> > > > --- a/simple-cam.cpp
> > > > +++ b/simple-cam.cpp
> > > > @@ -299,7 +299,7 @@ int main()
> > > >  			return EXIT_FAILURE;
> > > >  		}
> > > >  
> > > > -		unsigned int allocated = allocator->buffers(cfg.stream()).size();
> > > > +		size_t allocated = allocator->buffers(cfg.stream()).size();
> > > >  		std::cout << "Allocated " << allocated << " buffers for stream" << std::endl;
> > > >  	}
> > > >  
> 
> -- 
> Regards,
> 
> Laurent Pinchart

--
Kieran

Patch
diff mbox series 

diff --git a/simple-cam.cpp b/simple-cam.cpp
index 350f68be7906..e374e45849dc 100644
--- a/simple-cam.cpp
+++ b/simple-cam.cpp
@@ -299,7 +299,7 @@  int main()
 			return EXIT_FAILURE;
 		}
 
-		unsigned int allocated = allocator->buffers(cfg.stream()).size();
+		size_t allocated = allocator->buffers(cfg.stream()).size();
 		std::cout << "Allocated " << allocated << " buffers for stream" << std::endl;
 	}