[libcamera-devel,v1] test: gstreamer: Remove unnecessary header file includes
diff mbox series

Message ID 20210924090002.1901913-1-vedantparanjape160201@gmail.com
State Accepted
Headers show
Series
  • [libcamera-devel,v1] test: gstreamer: Remove unnecessary header file includes
Related show

Commit Message

Vedant Paranjape Sept. 24, 2021, 9 a.m. UTC
Remove header files which were not being used in the test code.
The following files, libcamera/base/utils.h and
libcamera/internal/source_paths.h were removed from includes.

Signed-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>
---
 test/gstreamer/gstreamer_single_stream_test.cpp | 4 ----
 1 file changed, 4 deletions(-)

Comments

Paul Elder Sept. 24, 2021, 9:09 a.m. UTC | #1
Hi Vedant,

On Fri, Sep 24, 2021 at 02:30:02PM +0530, Vedant Paranjape wrote:
> Remove header files which were not being used in the test code.
> The following files, libcamera/base/utils.h and
> libcamera/internal/source_paths.h were removed from includes.
> 
> Signed-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  test/gstreamer/gstreamer_single_stream_test.cpp | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp
> index 4a12e7957725..a0dd12cfea84 100644
> --- a/test/gstreamer/gstreamer_single_stream_test.cpp
> +++ b/test/gstreamer/gstreamer_single_stream_test.cpp
> @@ -8,10 +8,6 @@
>  #include <iostream>
>  #include <unistd.h>
>  
> -#include <libcamera/base/utils.h>
> -
> -#include "libcamera/internal/source_paths.h"
> -
>  #include <gst/gst.h>
>  
>  #include "gstreamer_test.h"
> -- 
> 2.25.1
>
Umang Jain Sept. 29, 2021, 6:23 a.m. UTC | #2
Hello,

On 9/24/21 2:39 PM, paul.elder@ideasonboard.com wrote:
> Hi Vedant,
>
> On Fri, Sep 24, 2021 at 02:30:02PM +0530, Vedant Paranjape wrote:
>> Remove header files which were not being used in the test code.
>> The following files, libcamera/base/utils.h and
>> libcamera/internal/source_paths.h were removed from includes.
>>
>> Signed-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>
> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>


Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
>
>> ---
>>   test/gstreamer/gstreamer_single_stream_test.cpp | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp
>> index 4a12e7957725..a0dd12cfea84 100644
>> --- a/test/gstreamer/gstreamer_single_stream_test.cpp
>> +++ b/test/gstreamer/gstreamer_single_stream_test.cpp
>> @@ -8,10 +8,6 @@
>>   #include <iostream>
>>   #include <unistd.h>
>>   
>> -#include <libcamera/base/utils.h>
>> -
>> -#include "libcamera/internal/source_paths.h"
>> -
>>   #include <gst/gst.h>
>>   
>>   #include "gstreamer_test.h"
>> -- 
>> 2.25.1
>>

Patch
diff mbox series

diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp
index 4a12e7957725..a0dd12cfea84 100644
--- a/test/gstreamer/gstreamer_single_stream_test.cpp
+++ b/test/gstreamer/gstreamer_single_stream_test.cpp
@@ -8,10 +8,6 @@ 
 #include <iostream>
 #include <unistd.h>
 
-#include <libcamera/base/utils.h>
-
-#include "libcamera/internal/source_paths.h"
-
 #include <gst/gst.h>
 
 #include "gstreamer_test.h"