[libcamera-devel] libcamera: Standardize URLs to git repositories
diff mbox series

Message ID 20210922120856.30735-1-laurent.pinchart@ideasonboard.com
State Superseded
Headers show
Series
  • [libcamera-devel] libcamera: Standardize URLs to git repositories
Related show

Commit Message

Laurent Pinchart Sept. 22, 2021, 12:08 p.m. UTC
When the libcamera project was started, we had no public git tree hosted
on git.libcamera.org. The problem has been addressed a while ago, and
the git.linuxtv.org repository is now a mirror of the main git tree. The
mirror is useful to benefit from the linuxtv.org automated compile
tests, but it can also confuse users who don't know where the official
version is. To try and clarify this, use the git.libcamera.org URL
consistently through the project.

This doesn't the validatity of the linuxtv.org repository which will
continue to mirror the libcamera.org repository.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 README.rst                                                | 2 +-
 package/gentoo/media-libs/libcamera/libcamera-9999.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


base-commit: a3b1539869ae53a6446a1c31bdade6560f91a46b

Comments

Umang Jain Sept. 22, 2021, 12:21 p.m. UTC | #1
Hi Laurent,

Thank you for the patch

On 9/22/21 5:38 PM, Laurent Pinchart wrote:
> When the libcamera project was started, we had no public git tree hosted
> on git.libcamera.org. The problem has been addressed a while ago, and
> the git.linuxtv.org repository is now a mirror of the main git tree. The


s/ git.linuxtv.org / git.linuxtv.org/libcamera.git/  maybe? or simply,

s/ git.linuxtv.org / git.linuxtv.org libcamera /

> mirror is useful to benefit from the linuxtv.org automated compile
> tests, but it can also confuse users who don't know where the official
> version is. To try and clarify this, use the git.libcamera.org URL
> consistently through the project.
>
> This doesn't the validatity of the linuxtv.org repository which will


s/doesn't /doesn't void / maybe?

> continue to mirror the libcamera.org repository.
>
> Signed-off-by: Laurent Pinchart<laurent.pinchart@ideasonboard.com>
> ---
>   README.rst                                                | 2 +-
>   package/gentoo/media-libs/libcamera/libcamera-9999.ebuild | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)


Should references to https://git.linuxtv.org/libcamera* inside 
Documentation/ be replaced as well?

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> diff --git a/README.rst b/README.rst
> index 6eb25c708180..a0cc45978b0b 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -32,7 +32,7 @@ To fetch the sources, build and install:
>   
>   ::
>   
> -  git clonegit://linuxtv.org/libcamera.git
> +  git clonehttps://git.libcamera.org/libcamera/libcamera.git
>     cd libcamera
>     meson build
>     ninja -C build install
> diff --git a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> index ca216c0ae909..65619e07d4ae 100644
> --- a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> +++ b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> @@ -8,7 +8,7 @@ inherit git-r3 meson python-any-r1
>   
>   DESCRIPTION="Camera support library for Linux"
>   HOMEPAGE="http://libcamera.org"
> -EGIT_REPO_URI="git://linuxtv.org/libcamera.git"
> +EGIT_REPO_URI="https://git.libcamera.org/libcamera/libcamera.git"
>   EGIT_BRANCH="master"
>   
>   LICENSE="LGPL-2.1+"
>
> base-commit: a3b1539869ae53a6446a1c31bdade6560f91a46b
Paul Elder Sept. 23, 2021, 3:57 a.m. UTC | #2
Hi Laurent,

On Wed, Sep 22, 2021 at 03:08:56PM +0300, Laurent Pinchart wrote:
> When the libcamera project was started, we had no public git tree hosted
> on git.libcamera.org. The problem has been addressed a while ago, and
> the git.linuxtv.org repository is now a mirror of the main git tree. The
> mirror is useful to benefit from the linuxtv.org automated compile
> tests, but it can also confuse users who don't know where the official
> version is. To try and clarify this, use the git.libcamera.org URL
> consistently through the project.
> 
> This doesn't the validatity of the linuxtv.org repository which will

doesn't what? :p

> continue to mirror the libcamera.org repository.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  README.rst                                                | 2 +-
>  package/gentoo/media-libs/libcamera/libcamera-9999.ebuild | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/README.rst b/README.rst
> index 6eb25c708180..a0cc45978b0b 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -32,7 +32,7 @@ To fetch the sources, build and install:
>  
>  ::
>  
> -  git clone git://linuxtv.org/libcamera.git
> +  git clone https://git.libcamera.org/libcamera/libcamera.git
>    cd libcamera
>    meson build
>    ninja -C build install
> diff --git a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> index ca216c0ae909..65619e07d4ae 100644
> --- a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> +++ b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> @@ -8,7 +8,7 @@ inherit git-r3 meson python-any-r1
>  
>  DESCRIPTION="Camera support library for Linux"
>  HOMEPAGE="http://libcamera.org"
> -EGIT_REPO_URI="git://linuxtv.org/libcamera.git"
> +EGIT_REPO_URI="https://git.libcamera.org/libcamera/libcamera.git"
>  EGIT_BRANCH="master"
>  
>  LICENSE="LGPL-2.1+"
> 
> base-commit: a3b1539869ae53a6446a1c31bdade6560f91a46b
Laurent Pinchart Sept. 23, 2021, 10:24 a.m. UTC | #3
Hi Umang,

On Wed, Sep 22, 2021 at 05:51:57PM +0530, Umang Jain wrote:
> On 9/22/21 5:38 PM, Laurent Pinchart wrote:
> > When the libcamera project was started, we had no public git tree hosted
> > on git.libcamera.org. The problem has been addressed a while ago, and
> > the git.linuxtv.org repository is now a mirror of the main git tree. The
> 
> s/ git.linuxtv.org / git.linuxtv.org/libcamera.git/  maybe? or simply,
> 
> s/ git.linuxtv.org / git.linuxtv.org libcamera /

I'll go for the latter.

> > mirror is useful to benefit from the linuxtv.org automated compile
> > tests, but it can also confuse users who don't know where the official
> > version is. To try and clarify this, use the git.libcamera.org URL
> > consistently through the project.
> >
> > This doesn't the validatity of the linuxtv.org repository which will
> 
> s/doesn't /doesn't void / maybe?

Oops :-) Yes

> > continue to mirror the libcamera.org repository.
> >
> > Signed-off-by: Laurent Pinchart<laurent.pinchart@ideasonboard.com>
> > ---
> >   README.rst                                                | 2 +-
> >   package/gentoo/media-libs/libcamera/libcamera-9999.ebuild | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Should references to https://git.linuxtv.org/libcamera* inside 
> Documentation/ be replaced as well?

How did I miss that ? I'll fix it in a v2.

> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> 
> > diff --git a/README.rst b/README.rst
> > index 6eb25c708180..a0cc45978b0b 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -32,7 +32,7 @@ To fetch the sources, build and install:
> >   
> >   ::
> >   
> > -  git clonegit://linuxtv.org/libcamera.git
> > +  git clonehttps://git.libcamera.org/libcamera/libcamera.git
> >     cd libcamera
> >     meson build
> >     ninja -C build install
> > diff --git a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> > index ca216c0ae909..65619e07d4ae 100644
> > --- a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> > +++ b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
> > @@ -8,7 +8,7 @@ inherit git-r3 meson python-any-r1
> >   
> >   DESCRIPTION="Camera support library for Linux"
> >   HOMEPAGE="http://libcamera.org"
> > -EGIT_REPO_URI="git://linuxtv.org/libcamera.git"
> > +EGIT_REPO_URI="https://git.libcamera.org/libcamera/libcamera.git"
> >   EGIT_BRANCH="master"
> >   
> >   LICENSE="LGPL-2.1+"
> >
> > base-commit: a3b1539869ae53a6446a1c31bdade6560f91a46b

Patch
diff mbox series

diff --git a/README.rst b/README.rst
index 6eb25c708180..a0cc45978b0b 100644
--- a/README.rst
+++ b/README.rst
@@ -32,7 +32,7 @@  To fetch the sources, build and install:
 
 ::
 
-  git clone git://linuxtv.org/libcamera.git
+  git clone https://git.libcamera.org/libcamera/libcamera.git
   cd libcamera
   meson build
   ninja -C build install
diff --git a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
index ca216c0ae909..65619e07d4ae 100644
--- a/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
+++ b/package/gentoo/media-libs/libcamera/libcamera-9999.ebuild
@@ -8,7 +8,7 @@  inherit git-r3 meson python-any-r1
 
 DESCRIPTION="Camera support library for Linux"
 HOMEPAGE="http://libcamera.org"
-EGIT_REPO_URI="git://linuxtv.org/libcamera.git"
+EGIT_REPO_URI="https://git.libcamera.org/libcamera/libcamera.git"
 EGIT_BRANCH="master"
 
 LICENSE="LGPL-2.1+"