| Message ID | 20210909150137.4011590-1-kieran.bingham@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 84acaac8b73ad4740ce0eff45421241f88ea0c7c |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran, Thank you for the patch. On Thu, Sep 09, 2021 at 04:01:37PM +0100, Kieran Bingham wrote: > While the distribution is unspecified, The README.rst gives > debian/ubuntu named dependencies for all except the android > requirements. > > Update the android dependencies to match the others, by showing that the > -dev package is required. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > README.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.rst b/README.rst > index cf81eca42149..6eb25c708180 100644 > --- a/README.rst > +++ b/README.rst > @@ -88,7 +88,7 @@ for tracing with lttng: [optional] > liblttng-ust-dev python3-jinja2 lttng-tools > > for android: [optional] > - libexif libjpeg libyaml > + libexif-dev libjpeg-dev libyaml-dev I'm curious to know how you'll use the Android camera HAL on a Debian-based distribution :-) It's coherent with the rest of the file though, so Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Using GStreamer plugin > ~~~~~~~~~~~~~~~~~~~~~~
On 09/09/2021 16:07, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thu, Sep 09, 2021 at 04:01:37PM +0100, Kieran Bingham wrote: >> While the distribution is unspecified, The README.rst gives >> debian/ubuntu named dependencies for all except the android >> requirements. >> >> Update the android dependencies to match the others, by showing that the >> -dev package is required. >> >> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >> --- >> README.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/README.rst b/README.rst >> index cf81eca42149..6eb25c708180 100644 >> --- a/README.rst >> +++ b/README.rst >> @@ -88,7 +88,7 @@ for tracing with lttng: [optional] >> liblttng-ust-dev python3-jinja2 lttng-tools >> >> for android: [optional] >> - libexif libjpeg libyaml >> + libexif-dev libjpeg-dev libyaml-dev > > I'm curious to know how you'll use the Android camera HAL on a > Debian-based distribution :-) It's coherent with the rest of the file > though, so True ... but I compile test with everything enabled, including Android, and saw this while trying to dockerise the build so the whole build environment was specified. It's mostly the consistency indeed here, as you're right. We wouldn't normally expect the android HAL to be compiled otherwise. It even makes me doubt the patch entirely ... > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >> Using GStreamer plugin >> ~~~~~~~~~~~~~~~~~~~~~~ >
Hi Kieran, On Thu, Sep 09, 2021 at 04:01:37PM +0100, Kieran Bingham wrote: > While the distribution is unspecified, The README.rst gives > debian/ubuntu named dependencies for all except the android > requirements. > > Update the android dependencies to match the others, by showing that the > -dev package is required. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > README.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.rst b/README.rst > index cf81eca42149..6eb25c708180 100644 > --- a/README.rst > +++ b/README.rst > @@ -88,7 +88,7 @@ for tracing with lttng: [optional] > liblttng-ust-dev python3-jinja2 lttng-tools > > for android: [optional] > - libexif libjpeg libyaml > + libexif-dev libjpeg-dev libyaml-dev > > Using GStreamer plugin > ~~~~~~~~~~~~~~~~~~~~~~ > -- > 2.30.2 >
Hi Kieran, thank you for the patch. On Fri, Sep 10, 2021 at 9:41 AM <paul.elder@ideasonboard.com> wrote: > > Hi Kieran, > > On Thu, Sep 09, 2021 at 04:01:37PM +0100, Kieran Bingham wrote: > > While the distribution is unspecified, The README.rst gives > > debian/ubuntu named dependencies for all except the android > > requirements. > > > > Update the android dependencies to match the others, by showing that the > > -dev package is required. > > > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > I thought the direction was opposite. I would rather drop "-dev" of other dependencies. A user shall look for proper packages in their platform for dependencies. Having "-dev" seems to centralize debian/ubuntu package systems. How about other distributions..? -Hiro > > --- > > README.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/README.rst b/README.rst > > index cf81eca42149..6eb25c708180 100644 > > --- a/README.rst > > +++ b/README.rst > > @@ -88,7 +88,7 @@ for tracing with lttng: [optional] > > liblttng-ust-dev python3-jinja2 lttng-tools > > > > for android: [optional] > > - libexif libjpeg libyaml > > + libexif-dev libjpeg-dev libyaml-dev > > > > Using GStreamer plugin > > ~~~~~~~~~~~~~~~~~~~~~~ > > -- > > 2.30.2 > >
Hi Hiro, On Fri, Sep 10, 2021 at 05:25:42PM +0900, Hirokazu Honda wrote: > On Fri, Sep 10, 2021 at 9:41 AM <paul.elder@ideasonboard.com> wrote: > > On Thu, Sep 09, 2021 at 04:01:37PM +0100, Kieran Bingham wrote: > > > While the distribution is unspecified, The README.rst gives > > > debian/ubuntu named dependencies for all except the android > > > requirements. > > > > > > Update the android dependencies to match the others, by showing that the > > > -dev package is required. > > > > > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > > I thought the direction was opposite. I would rather drop "-dev" of > other dependencies. > A user shall look for proper packages in their platform for dependencies. > Having "-dev" seems to centralize debian/ubuntu package systems. How > about other distributions..? Most of us, and it seems a large part of our users, use Debian-based distributions (I use Gentoo personally ;-)). I think it would be nice to list depednencies for other distributions too, if someone wants to submit a patch. I'm not sure how to best format the data though, we may need to turn it into a table. > > > --- > > > README.rst | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/README.rst b/README.rst > > > index cf81eca42149..6eb25c708180 100644 > > > --- a/README.rst > > > +++ b/README.rst > > > @@ -88,7 +88,7 @@ for tracing with lttng: [optional] > > > liblttng-ust-dev python3-jinja2 lttng-tools > > > > > > for android: [optional] > > > - libexif libjpeg libyaml > > > + libexif-dev libjpeg-dev libyaml-dev > > > > > > Using GStreamer plugin > > > ~~~~~~~~~~~~~~~~~~~~~~
Hi Laurent, On Sat, Sep 11, 2021 at 12:00 AM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Hiro, > > On Fri, Sep 10, 2021 at 05:25:42PM +0900, Hirokazu Honda wrote: > > On Fri, Sep 10, 2021 at 9:41 AM <paul.elder@ideasonboard.com> wrote: > > > On Thu, Sep 09, 2021 at 04:01:37PM +0100, Kieran Bingham wrote: > > > > While the distribution is unspecified, The README.rst gives > > > > debian/ubuntu named dependencies for all except the android > > > > requirements. > > > > > > > > Update the android dependencies to match the others, by showing that the > > > > -dev package is required. > > > > > > > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > > > > I thought the direction was opposite. I would rather drop "-dev" of > > other dependencies. > > A user shall look for proper packages in their platform for dependencies. > > Having "-dev" seems to centralize debian/ubuntu package systems. How > > about other distributions..? > > Most of us, and it seems a large part of our users, use Debian-based > distributions (I use Gentoo personally ;-)). I think it would be nice to > list depednencies for other distributions too, if someone wants to > submit a patch. I'm not sure how to best format the data though, we may > need to turn it into a table. > I sometimes see the command lines to install dependent packages in each systems like Debian/Ubuntu `apt install ....` Arch Linux `pacman -S` Anyway, I am not against this patch of fixing the consistency. Reviewed-by: Hirokazu Honda <hiroh@chromium.org> -Hiro > > > > --- > > > > README.rst | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/README.rst b/README.rst > > > > index cf81eca42149..6eb25c708180 100644 > > > > --- a/README.rst > > > > +++ b/README.rst > > > > @@ -88,7 +88,7 @@ for tracing with lttng: [optional] > > > > liblttng-ust-dev python3-jinja2 lttng-tools > > > > > > > > for android: [optional] > > > > - libexif libjpeg libyaml > > > > + libexif-dev libjpeg-dev libyaml-dev > > > > > > > > Using GStreamer plugin > > > > ~~~~~~~~~~~~~~~~~~~~~~ > > -- > Regards, > > Laurent Pinchart
On 10/09/2021 17:07, Hirokazu Honda wrote: > Hi Laurent, > > On Sat, Sep 11, 2021 at 12:00 AM Laurent Pinchart > <laurent.pinchart@ideasonboard.com> wrote: >> >> Hi Hiro, >> >> On Fri, Sep 10, 2021 at 05:25:42PM +0900, Hirokazu Honda wrote: >>> On Fri, Sep 10, 2021 at 9:41 AM <paul.elder@ideasonboard.com> wrote: >>>> On Thu, Sep 09, 2021 at 04:01:37PM +0100, Kieran Bingham wrote: >>>>> While the distribution is unspecified, The README.rst gives >>>>> debian/ubuntu named dependencies for all except the android >>>>> requirements. >>>>> >>>>> Update the android dependencies to match the others, by showing that the >>>>> -dev package is required. >>>>> >>>>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >>>> >>>> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> >>> >>> I thought the direction was opposite. I would rather drop "-dev" of >>> other dependencies. >>> A user shall look for proper packages in their platform for dependencies. >>> Having "-dev" seems to centralize debian/ubuntu package systems. How >>> about other distributions..? >> >> Most of us, and it seems a large part of our users, use Debian-based >> distributions (I use Gentoo personally ;-)). I think it would be nice to >> list depednencies for other distributions too, if someone wants to >> submit a patch. I'm not sure how to best format the data though, we may >> need to turn it into a table. >> > > I sometimes see the command lines to install dependent packages in > each systems like > Debian/Ubuntu > `apt install ....` > Arch Linux > `pacman -S` One of my half baked ideas was to put these dependencies in a table in a script and allow: ./utils/bootstrap-deps.sh gcc cam qcam gstreamer hotplug or ./utils/bootstrap-deps.sh all which would install the relevant dependencies for those categories. It's stashed on one of my development branches waiting for some inspiration or motivation to make it more generic. If anyone is interested in having a go at continuing it ... https://gist.github.com/kbingham/667e2b95acfbbdd726764fcee632c8b0 > Anyway, I am not against this patch of fixing the consistency. > > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Thanks, I'd rather merge this for consistency, and if we later decide to use just the library names adapt then. But somehow we might want to distinguish between runtime and compile time dependencies if we make it generic... > > -Hiro >>>>> --- >>>>> README.rst | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/README.rst b/README.rst >>>>> index cf81eca42149..6eb25c708180 100644 >>>>> --- a/README.rst >>>>> +++ b/README.rst >>>>> @@ -88,7 +88,7 @@ for tracing with lttng: [optional] >>>>> liblttng-ust-dev python3-jinja2 lttng-tools >>>>> >>>>> for android: [optional] >>>>> - libexif libjpeg libyaml >>>>> + libexif-dev libjpeg-dev libyaml-dev >>>>> >>>>> Using GStreamer plugin >>>>> ~~~~~~~~~~~~~~~~~~~~~~ >> >> -- >> Regards, >> >> Laurent Pinchart
diff --git a/README.rst b/README.rst index cf81eca42149..6eb25c708180 100644 --- a/README.rst +++ b/README.rst @@ -88,7 +88,7 @@ for tracing with lttng: [optional] liblttng-ust-dev python3-jinja2 lttng-tools for android: [optional] - libexif libjpeg libyaml + libexif-dev libjpeg-dev libyaml-dev Using GStreamer plugin ~~~~~~~~~~~~~~~~~~~~~~
While the distribution is unspecified, The README.rst gives debian/ubuntu named dependencies for all except the android requirements. Update the android dependencies to match the others, by showing that the -dev package is required. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)