| Message ID | 20210907194107.803730-13-jacopo@jmondi.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, Thank you for the patch. On Tue, Sep 07, 2021 at 09:41:02PM +0200, Jacopo Mondi wrote: > Add a debug statement to print out the list of collected output stream > and their characteristics. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > --- > src/android/camera_capabilities.cpp | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp > index e5cfe67f9b73..ba800b545b9d 100644 > --- a/src/android/camera_capabilities.cpp > +++ b/src/android/camera_capabilities.cpp > @@ -1279,6 +1279,13 @@ int CameraCapabilities::initializeStaticMetadata() > availableStreamConfigurations.push_back(entry.resolution.height); > availableStreamConfigurations.push_back( > ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT); > + > + LOG(HAL, Debug) > + << "Output Stream: " << utils::hex(entry.androidFormat) > + << " (" << entry.resolution.width << "x" > + << entry.resolution.height << ")[" You can use entry.resolution.toString() instead of open-coding it. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + << entry.minFrameDurationNsec << "]" > + << "@" << fps; > } > staticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS, > availableStreamConfigurations);
diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp index e5cfe67f9b73..ba800b545b9d 100644 --- a/src/android/camera_capabilities.cpp +++ b/src/android/camera_capabilities.cpp @@ -1279,6 +1279,13 @@ int CameraCapabilities::initializeStaticMetadata() availableStreamConfigurations.push_back(entry.resolution.height); availableStreamConfigurations.push_back( ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS_OUTPUT); + + LOG(HAL, Debug) + << "Output Stream: " << utils::hex(entry.androidFormat) + << " (" << entry.resolution.width << "x" + << entry.resolution.height << ")[" + << entry.minFrameDurationNsec << "]" + << "@" << fps; } staticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS, availableStreamConfigurations);