[libcamera-devel,15/16] Revert "android: capabilities: Cap frame rate to 30 FPS"
diff mbox series

Message ID 20210827120757.110615-16-jacopo@jmondi.org
State Superseded
Headers show
Series
  • IPU3 control info update and HAL frame durations
Related show

Commit Message

Jacopo Mondi Aug. 27, 2021, 12:07 p.m. UTC 
This reverts commit 257df463ad0e0862c211b03742140a99dd8cc0ef.
---
 src/android/camera_capabilities.cpp | 23 -----------------------
 1 file changed, 23 deletions(-)

Patch
diff mbox series 

diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp
index 6890bfecab29..01cdbcf1395d 100644
--- a/src/android/camera_capabilities.cpp
+++ b/src/android/camera_capabilities.cpp
@@ -632,29 +632,6 @@  int CameraCapabilities::initializeStreamConfigurations()
 
 			int64_t minFrameDuration = frameDurations->second.min().get<int64_t>() * 1000;
 			int64_t maxFrameDuration = frameDurations->second.max().get<int64_t>() * 1000;
-
-			/*
-			 * Cap min frame duration to 30 FPS.
-			 *
-			 * 30 frames per second has been validated as the most
-			 * opportune frame rate for quality tuning, and power
-			 * vs performances budget on Intel IPU3.
-			 *
-			 * \todo This is a platform-specific decision that needs
-			 * to be abstracted and delegated to the configuration
-			 * file.
-			 *
-			 * \todo libcamera only allows to control frame duration
-			 * through the per-request controls::FrameDuration
-			 * control. If we cap the durations here, we should be
-			 * capable of configuring the camera to operate at such
-			 * duration without requiring to have the FrameDuration
-			 * control to be specified for each Request. Defer this
-			 * to the in-development configuration API rework.
-			 */
-			if (minFrameDuration < 1e9 / 30.0)
-				minFrameDuration = 1e9 / 30.0;
-
 			streamConfigurations_.push_back({
 				res, androidFormat, minFrameDuration, maxFrameDuration,
 			});