[libcamera-devel,1/9] libcamera: camera_manager: Remove put() method

Message ID 20190103013110.6849-1-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-devel,1/9] libcamera: camera_manager: Remove put() method
Related show

Commit Message

Laurent Pinchart Jan. 3, 2019, 1:31 a.m. UTC
The method is declared but not implemented. Remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 include/libcamera/camera_manager.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Niklas Söderlund Jan. 3, 2019, 9:16 p.m. UTC | #1
Hi Laurent,

Thanks for your work.

On 2019-01-03 03:31:02 +0200, Laurent Pinchart wrote:
> The method is declared but not implemented. Remove it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  include/libcamera/camera_manager.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h
> index 9d032d71c4c0..43a7811b3ea2 100644
> --- a/include/libcamera/camera_manager.h
> +++ b/include/libcamera/camera_manager.h
> @@ -26,7 +26,6 @@ public:
>  
>  	std::vector<std::string> list() const;
>  	Camera *get(const std::string &name);
> -	void put(Camera *camera);
>  
>  private:
>  	DeviceEnumerator *enumerator_;
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h
index 9d032d71c4c0..43a7811b3ea2 100644
--- a/include/libcamera/camera_manager.h
+++ b/include/libcamera/camera_manager.h
@@ -26,7 +26,6 @@  public:
 
 	std::vector<std::string> list() const;
 	Camera *get(const std::string &name);
-	void put(Camera *camera);
 
 private:
 	DeviceEnumerator *enumerator_;