[libcamera-devel,v3,1/3] src: Remove all unused sys/mman.h inclusions
diff mbox series

Message ID 20210809132929.1824114-2-kieran.bingham@ideasonboard.com
State Accepted
Headers show
Series
  • MappedFrameBuffer: Move its own component.
Related show

Commit Message

Kieran Bingham Aug. 9, 2021, 1:29 p.m. UTC 
Remove leftover inclusions of the sys/mman header file.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/android/camera_device.cpp                      | 1 -
 src/libcamera/ipa_module.cpp                       | 1 -
 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -
 src/libcamera/v4l2_videodevice.cpp                 | 1 -
 src/v4l2/v4l2_camera_proxy.h                       | 1 -
 src/v4l2/v4l2_compat_manager.h                     | 1 -
 6 files changed, 6 deletions(-)

Comments

Laurent Pinchart Aug. 9, 2021, 2:15 p.m. UTC | #1 
Hi Kieran,

Thank you for the patch.

On Mon, Aug 09, 2021 at 02:29:27PM +0100, Kieran Bingham wrote:
> Remove leftover inclusions of the sys/mman header file.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/android/camera_device.cpp                      | 1 -
>  src/libcamera/ipa_module.cpp                       | 1 -
>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -
>  src/libcamera/v4l2_videodevice.cpp                 | 1 -
>  src/v4l2/v4l2_camera_proxy.h                       | 1 -
>  src/v4l2/v4l2_compat_manager.h                     | 1 -
>  6 files changed, 6 deletions(-)
> 
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 3266c495d0ca..59b37bc864b5 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -12,7 +12,6 @@
>  
>  #include <algorithm>
>  #include <fstream>
> -#include <sys/mman.h>
>  #include <unistd.h>
>  #include <vector>
>  
> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp
> index 7c52ad8d5796..908f2e07bd3f 100644
> --- a/src/libcamera/ipa_module.cpp
> +++ b/src/libcamera/ipa_module.cpp
> @@ -16,7 +16,6 @@
>  #include <fcntl.h>
>  #include <link.h>
>  #include <string.h>
> -#include <sys/mman.h>
>  #include <sys/stat.h>
>  #include <sys/types.h>
>  #include <unistd.h>
> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> index 0bab3bedd402..2e8774ae360d 100644
> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> @@ -10,7 +10,6 @@
>  #include <memory>
>  #include <mutex>
>  #include <queue>
> -#include <sys/mman.h>
>  #include <unordered_set>
>  
>  #include <libcamera/camera.h>
> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp
> index da2af6a13dfb..cddabad753e1 100644
> --- a/src/libcamera/v4l2_videodevice.cpp
> +++ b/src/libcamera/v4l2_videodevice.cpp
> @@ -13,7 +13,6 @@
>  #include <sstream>
>  #include <string.h>
>  #include <sys/ioctl.h>
> -#include <sys/mman.h>
>  #include <sys/syscall.h>
>  #include <sys/time.h>
>  #include <unistd.h>
> diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h
> index 92a79abb9e21..f1a8b61c5eac 100644
> --- a/src/v4l2/v4l2_camera_proxy.h
> +++ b/src/v4l2/v4l2_camera_proxy.h
> @@ -12,7 +12,6 @@
>  #include <map>
>  #include <memory>
>  #include <set>
> -#include <sys/mman.h>
>  #include <sys/types.h>
>  #include <vector>
>  
> diff --git a/src/v4l2/v4l2_compat_manager.h b/src/v4l2/v4l2_compat_manager.h
> index bc548ab2a8bd..1ec46162211d 100644
> --- a/src/v4l2/v4l2_compat_manager.h
> +++ b/src/v4l2/v4l2_compat_manager.h
> @@ -11,7 +11,6 @@
>  #include <fcntl.h>
>  #include <map>
>  #include <memory>
> -#include <sys/mman.h>
>  #include <sys/types.h>
>  #include <vector>
>
Hirokazu Honda Aug. 10, 2021, 2:40 a.m. UTC | #2 
Hi Kieran, thank you for the patch.

On Mon, Aug 9, 2021 at 11:15 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Kieran,
>
> Thank you for the patch.
>
> On Mon, Aug 09, 2021 at 02:29:27PM +0100, Kieran Bingham wrote:
> > Remove leftover inclusions of the sys/mman header file.
> >
> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>

Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

> > ---
> >  src/android/camera_device.cpp                      | 1 -
> >  src/libcamera/ipa_module.cpp                       | 1 -
> >  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 1 -
> >  src/libcamera/v4l2_videodevice.cpp                 | 1 -
> >  src/v4l2/v4l2_camera_proxy.h                       | 1 -
> >  src/v4l2/v4l2_compat_manager.h                     | 1 -
> >  6 files changed, 6 deletions(-)
> >
> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> > index 3266c495d0ca..59b37bc864b5 100644
> > --- a/src/android/camera_device.cpp
> > +++ b/src/android/camera_device.cpp
> > @@ -12,7 +12,6 @@
> >
> >  #include <algorithm>
> >  #include <fstream>
> > -#include <sys/mman.h>
> >  #include <unistd.h>
> >  #include <vector>
> >
> > diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp
> > index 7c52ad8d5796..908f2e07bd3f 100644
> > --- a/src/libcamera/ipa_module.cpp
> > +++ b/src/libcamera/ipa_module.cpp
> > @@ -16,7 +16,6 @@
> >  #include <fcntl.h>
> >  #include <link.h>
> >  #include <string.h>
> > -#include <sys/mman.h>
> >  #include <sys/stat.h>
> >  #include <sys/types.h>
> >  #include <unistd.h>
> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> > index 0bab3bedd402..2e8774ae360d 100644
> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> > @@ -10,7 +10,6 @@
> >  #include <memory>
> >  #include <mutex>
> >  #include <queue>
> > -#include <sys/mman.h>
> >  #include <unordered_set>
> >
> >  #include <libcamera/camera.h>
> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp
> > index da2af6a13dfb..cddabad753e1 100644
> > --- a/src/libcamera/v4l2_videodevice.cpp
> > +++ b/src/libcamera/v4l2_videodevice.cpp
> > @@ -13,7 +13,6 @@
> >  #include <sstream>
> >  #include <string.h>
> >  #include <sys/ioctl.h>
> > -#include <sys/mman.h>
> >  #include <sys/syscall.h>
> >  #include <sys/time.h>
> >  #include <unistd.h>
> > diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h
> > index 92a79abb9e21..f1a8b61c5eac 100644
> > --- a/src/v4l2/v4l2_camera_proxy.h
> > +++ b/src/v4l2/v4l2_camera_proxy.h
> > @@ -12,7 +12,6 @@
> >  #include <map>
> >  #include <memory>
> >  #include <set>
> > -#include <sys/mman.h>
> >  #include <sys/types.h>
> >  #include <vector>
> >
> > diff --git a/src/v4l2/v4l2_compat_manager.h b/src/v4l2/v4l2_compat_manager.h
> > index bc548ab2a8bd..1ec46162211d 100644
> > --- a/src/v4l2/v4l2_compat_manager.h
> > +++ b/src/v4l2/v4l2_compat_manager.h
> > @@ -11,7 +11,6 @@
> >  #include <fcntl.h>
> >  #include <map>
> >  #include <memory>
> > -#include <sys/mman.h>
> >  #include <sys/types.h>
> >  #include <vector>
> >
>
> --
> Regards,
>
> Laurent Pinchart

Patch
diff mbox series 

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index 3266c495d0ca..59b37bc864b5 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -12,7 +12,6 @@ 
 
 #include <algorithm>
 #include <fstream>
-#include <sys/mman.h>
 #include <unistd.h>
 #include <vector>
 
diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp
index 7c52ad8d5796..908f2e07bd3f 100644
--- a/src/libcamera/ipa_module.cpp
+++ b/src/libcamera/ipa_module.cpp
@@ -16,7 +16,6 @@ 
 #include <fcntl.h>
 #include <link.h>
 #include <string.h>
-#include <sys/mman.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <unistd.h>
diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
index 0bab3bedd402..2e8774ae360d 100644
--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
@@ -10,7 +10,6 @@ 
 #include <memory>
 #include <mutex>
 #include <queue>
-#include <sys/mman.h>
 #include <unordered_set>
 
 #include <libcamera/camera.h>
diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp
index da2af6a13dfb..cddabad753e1 100644
--- a/src/libcamera/v4l2_videodevice.cpp
+++ b/src/libcamera/v4l2_videodevice.cpp
@@ -13,7 +13,6 @@ 
 #include <sstream>
 #include <string.h>
 #include <sys/ioctl.h>
-#include <sys/mman.h>
 #include <sys/syscall.h>
 #include <sys/time.h>
 #include <unistd.h>
diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h
index 92a79abb9e21..f1a8b61c5eac 100644
--- a/src/v4l2/v4l2_camera_proxy.h
+++ b/src/v4l2/v4l2_camera_proxy.h
@@ -12,7 +12,6 @@ 
 #include <map>
 #include <memory>
 #include <set>
-#include <sys/mman.h>
 #include <sys/types.h>
 #include <vector>
 
diff --git a/src/v4l2/v4l2_compat_manager.h b/src/v4l2/v4l2_compat_manager.h
index bc548ab2a8bd..1ec46162211d 100644
--- a/src/v4l2/v4l2_compat_manager.h
+++ b/src/v4l2/v4l2_compat_manager.h
@@ -11,7 +11,6 @@ 
 #include <fcntl.h>
 #include <map>
 #include <memory>
-#include <sys/mman.h>
 #include <sys/types.h>
 #include <vector>