[libcamera-devel,2/2] android: nautilus: Add camera HAL configuration
diff mbox series

Message ID 20210727135440.53640-3-umang.jain@ideasonboard.com
State Superseded
Headers show
Series
  • android: Handle internal UVC cameras
Related show

Commit Message

Umang Jain July 27, 2021, 1:54 p.m. UTC
Nautilus has two in-built cameras, one UVC and one attached to IPU3.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/android/data/nautilus/camera_hal.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 src/android/data/nautilus/camera_hal.yaml

Comments

Laurent Pinchart July 27, 2021, 3:27 p.m. UTC | #1
Hi Umang,

Thank you for the patch.

On Tue, Jul 27, 2021 at 07:24:40PM +0530, Umang Jain wrote:
> Nautilus has two in-built cameras, one UVC and one attached to IPU3.
> 
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/android/data/nautilus/camera_hal.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 src/android/data/nautilus/camera_hal.yaml
> 
> diff --git a/src/android/data/nautilus/camera_hal.yaml b/src/android/data/nautilus/camera_hal.yaml
> new file mode 100644
> index 00000000..faddd29e
> --- /dev/null
> +++ b/src/android/data/nautilus/camera_hal.yaml
> @@ -0,0 +1,8 @@
> +cameras:
> +  "\\_SB_.PCI0.I2C2.CAM0":
> +    location: back
> +    rotation: 0
> +
> +  "\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647":
> +    location: front
> +    rotation: 0
Kieran Bingham July 27, 2021, 3:41 p.m. UTC | #2
On 27/07/2021 16:27, Laurent Pinchart wrote:
> Hi Umang,
> 
> Thank you for the patch.
> 
> On Tue, Jul 27, 2021 at 07:24:40PM +0530, Umang Jain wrote:
>> Nautilus has two in-built cameras, one UVC and one attached to IPU3.
>>
>> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

And

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
>> ---
>>  src/android/data/nautilus/camera_hal.yaml | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>  create mode 100644 src/android/data/nautilus/camera_hal.yaml
>>
>> diff --git a/src/android/data/nautilus/camera_hal.yaml b/src/android/data/nautilus/camera_hal.yaml
>> new file mode 100644
>> index 00000000..faddd29e
>> --- /dev/null
>> +++ b/src/android/data/nautilus/camera_hal.yaml
>> @@ -0,0 +1,8 @@
>> +cameras:
>> +  "\\_SB_.PCI0.I2C2.CAM0":
>> +    location: back
>> +    rotation: 0
>> +
>> +  "\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647":
>> +    location: front
>> +    rotation: 0
>

Patch
diff mbox series

diff --git a/src/android/data/nautilus/camera_hal.yaml b/src/android/data/nautilus/camera_hal.yaml
new file mode 100644
index 00000000..faddd29e
--- /dev/null
+++ b/src/android/data/nautilus/camera_hal.yaml
@@ -0,0 +1,8 @@ 
+cameras:
+  "\\_SB_.PCI0.I2C2.CAM0":
+    location: back
+    rotation: 0
+
+  "\\_SB_.PCI0.XHCI.RHUB.HS09-9:1.0-04f2:b647":
+    location: front
+    rotation: 0