Message ID | 20210720101743.26676-1-paul.elder@ideasonboard.com |
---|---|
State | Accepted |
Headers | show |
Series |
|
Related | show |
Hi Paul, Thank you for the patch. On Tue, Jul 20, 2021 at 07:17:43PM +0900, Paul Elder wrote: > The pkgconfig name was changed from camera to libcamera, but the > application developer guide wasn't updated. Update it to refer to the > new name. > > Bug: https://bugs.libcamera.org/show_bug.cgi?id=65 > Fixes: ec7afef6 ("libcamera: Rename libcamera pkg-config generation") > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Changes in v2: > - fix another line that went unnoticed > --- > Documentation/guides/application-developer.rst | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst > index e3430f03..e0bbbad4 100644 > --- a/Documentation/guides/application-developer.rst > +++ b/Documentation/guides/application-developer.rst > @@ -596,12 +596,12 @@ has been installed in your system. > > export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/ > > -Verify that ``pkg-config`` can identify the ``camera`` library with > +Verify that ``pkg-config`` can identify the ``libcamera`` library with > > .. code:: shell > > - $ pkg-config --libs --cflags camera > - -I/usr/local/include/libcamera -L/usr/local/lib -lcamera > + $ pkg-config --libs --cflags libcamera > + -I/usr/local/include/libcamera -L/usr/local/lib -lcamera -lcamera-base > > ``meson`` can alternatively use ``cmake`` to locate packages, please refer to > the ``meson`` documentation if you prefer to use it in place of ``pkgconfig`` > @@ -621,11 +621,11 @@ accordingly. In this example, the application file has been named > > simpler_cam = executable('simple-cam', > 'simple-cam.cpp', > - dependencies: dependency('camera', required : true)) > + dependencies: dependency('libcamera', required : true)) > > The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to > -locate the ``camera`` library, (libcamera without the lib prefix) which the test > -application will be dynamically linked against. > +locate the ``libcamera`` library, which the test application will be > +dynamically linked against. > > With the build file in place, compile and run the application with: >
Hi Paul, On 20/07/2021 11:17, Paul Elder wrote: > The pkgconfig name was changed from camera to libcamera, but the > application developer guide wasn't updated. Update it to refer to the > new name. Oops. Sorry :-( > Bug: https://bugs.libcamera.org/show_bug.cgi?id=65 > Fixes: ec7afef6 ("libcamera: Rename libcamera pkg-config generation") > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > Changes in v2: > - fix another line that went unnoticed > --- > Documentation/guides/application-developer.rst | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst > index e3430f03..e0bbbad4 100644 > --- a/Documentation/guides/application-developer.rst > +++ b/Documentation/guides/application-developer.rst > @@ -596,12 +596,12 @@ has been installed in your system. > > export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/ > > -Verify that ``pkg-config`` can identify the ``camera`` library with > +Verify that ``pkg-config`` can identify the ``libcamera`` library with > > .. code:: shell > > - $ pkg-config --libs --cflags camera > - -I/usr/local/include/libcamera -L/usr/local/lib -lcamera > + $ pkg-config --libs --cflags libcamera > + -I/usr/local/include/libcamera -L/usr/local/lib -lcamera -lcamera-base > > ``meson`` can alternatively use ``cmake`` to locate packages, please refer to > the ``meson`` documentation if you prefer to use it in place of ``pkgconfig`` > @@ -621,11 +621,11 @@ accordingly. In this example, the application file has been named > > simpler_cam = executable('simple-cam', > 'simple-cam.cpp', > - dependencies: dependency('camera', required : true)) > + dependencies: dependency('libcamera', required : true)) > > The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to > -locate the ``camera`` library, (libcamera without the lib prefix) which the test > -application will be dynamically linked against. > +locate the ``libcamera`` library, which the test application will be > +dynamically linked against. > > With the build file in place, compile and run the application with: > >
diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst index e3430f03..e0bbbad4 100644 --- a/Documentation/guides/application-developer.rst +++ b/Documentation/guides/application-developer.rst @@ -596,12 +596,12 @@ has been installed in your system. export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/ -Verify that ``pkg-config`` can identify the ``camera`` library with +Verify that ``pkg-config`` can identify the ``libcamera`` library with .. code:: shell - $ pkg-config --libs --cflags camera - -I/usr/local/include/libcamera -L/usr/local/lib -lcamera + $ pkg-config --libs --cflags libcamera + -I/usr/local/include/libcamera -L/usr/local/lib -lcamera -lcamera-base ``meson`` can alternatively use ``cmake`` to locate packages, please refer to the ``meson`` documentation if you prefer to use it in place of ``pkgconfig`` @@ -621,11 +621,11 @@ accordingly. In this example, the application file has been named simpler_cam = executable('simple-cam', 'simple-cam.cpp', - dependencies: dependency('camera', required : true)) + dependencies: dependency('libcamera', required : true)) The ``dependencies`` line instructs meson to ask ``pkgconfig`` (or ``cmake``) to -locate the ``camera`` library, (libcamera without the lib prefix) which the test -application will be dynamically linked against. +locate the ``libcamera`` library, which the test application will be +dynamically linked against. With the build file in place, compile and run the application with:
The pkgconfig name was changed from camera to libcamera, but the application developer guide wasn't updated. Update it to refer to the new name. Bug: https://bugs.libcamera.org/show_bug.cgi?id=65 Fixes: ec7afef6 ("libcamera: Rename libcamera pkg-config generation") Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- Changes in v2: - fix another line that went unnoticed --- Documentation/guides/application-developer.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)