[libcamera-devel,v2,07/30] cam: options: Disable copy for parsers
diff mbox series

Message ID 20210712215645.30478-8-laurent.pinchart@ideasonboard.com
State Superseded
Headers show
Series
  • Multi-camera support in the cam application
Related show

Commit Message

Laurent Pinchart July 12, 2021, 9:56 p.m. UTC 
Copying the OptionsParser class would result in the optionsMap_ entries
pointing to Option entries of the original instance. As there's no use
case for copying the class, disable copying.

Disable copying of KeyValueParser as well for consistency as there's no
use case either.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/cam/options.h | 6 ++++++
 1 file changed, 6 insertions(+)

Patch
diff mbox series 

diff --git a/src/cam/options.h b/src/cam/options.h
index 01a5d36a63fb..4418e201bf1f 100644
--- a/src/cam/options.h
+++ b/src/cam/options.h
@@ -68,6 +68,9 @@  public:
 	virtual Options parse(const char *arguments);
 
 private:
+	KeyValueParser(const KeyValueParser &) = delete;
+	KeyValueParser &operator=(const KeyValueParser &) = delete;
+
 	friend class OptionsParser;
 	void usage(int indent);
 
@@ -95,6 +98,9 @@  public:
 	void usage();
 
 private:
+	OptionsParser(const OptionsParser &) = delete;
+	OptionsParser &operator=(const OptionsParser &) = delete;
+
 	void usageOptions(const std::list<Option> &options, unsigned int indent);
 
 	std::list<Option> options_;