[libcamera-devel] libcamera: device_enumerator: Drop inclusion of linux/media.h
diff mbox series

Message ID 20210704221028.30551-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit fb37998816724349543da697b79feeff27826c6b
Delegated to: Laurent Pinchart
Headers show
Series
  • [libcamera-devel] libcamera: device_enumerator: Drop inclusion of linux/media.h
Related show

Commit Message

Laurent Pinchart July 4, 2021, 10:10 p.m. UTC
device_enumerator.h doesn't need to include linux/media.h. Drop
inclusion of the header.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 include/libcamera/internal/device_enumerator.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Umang Jain July 5, 2021, 4:51 a.m. UTC | #1
Hi Laurent,

Thanks for the patch.

On 7/5/21 3:40 AM, Laurent Pinchart wrote:
> device_enumerator.h doesn't need to include linux/media.h. Drop
> inclusion of the header.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Tested-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   include/libcamera/internal/device_enumerator.h | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h
> index 222caf75a0db..baccfc000d87 100644
> --- a/include/libcamera/internal/device_enumerator.h
> +++ b/include/libcamera/internal/device_enumerator.h
> @@ -11,8 +11,6 @@
>   #include <string>
>   #include <vector>
>   
> -#include <linux/media.h>
> -
>   #include <libcamera/base/signal.h>
>   
>   namespace libcamera {
Jacopo Mondi July 5, 2021, 10:16 a.m. UTC | #2
Hi Laurent,

On Mon, Jul 05, 2021 at 01:10:28AM +0300, Laurent Pinchart wrote:
> device_enumerator.h doesn't need to include linux/media.h. Drop
> inclusion of the header.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

> ---
>  include/libcamera/internal/device_enumerator.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h
> index 222caf75a0db..baccfc000d87 100644
> --- a/include/libcamera/internal/device_enumerator.h
> +++ b/include/libcamera/internal/device_enumerator.h
> @@ -11,8 +11,6 @@
>  #include <string>
>  #include <vector>
>
> -#include <linux/media.h>
> -
>  #include <libcamera/base/signal.h>
>
>  namespace libcamera {
> --
> Regards,
>
> Laurent Pinchart
>

Patch
diff mbox series

diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h
index 222caf75a0db..baccfc000d87 100644
--- a/include/libcamera/internal/device_enumerator.h
+++ b/include/libcamera/internal/device_enumerator.h
@@ -11,8 +11,6 @@ 
 #include <string>
 #include <vector>
 
-#include <linux/media.h>
-
 #include <libcamera/base/signal.h>
 
 namespace libcamera {