[libcamera-devel,3/4] ipa: raspberrypi: Increase the default max frame duration to 250s
diff mbox series

Message ID 20210614100040.3054433-4-naush@raspberrypi.com
State Superseded
Headers show
Series
  • Raspberry Pi: Enable imx477 long exposure modes
Related show

Commit Message

Naushir Patuck June 14, 2021, 10 a.m. UTC
With the recent change to allow long exposures on the imx477, the existing 100s
limit was not adequate.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
 src/ipa/raspberrypi/raspberrypi.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Plowman June 15, 2021, 1:36 p.m. UTC | #1
Hi Naush

Thanks for the patch.

On Mon, 14 Jun 2021 at 11:00, Naushir Patuck <naush@raspberrypi.com> wrote:
>
> With the recent change to allow long exposures on the imx477, the existing 100s
> limit was not adequate.
>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 1c1e802a2cdc..8a8e9c0a52ab 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -61,7 +61,7 @@ using utils::Duration;
>  constexpr double DefaultAnalogueGain = 1.0;
>  constexpr Duration DefaultExposureTime = 20.0ms;
>  constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;
> -constexpr Duration defaultMaxFrameDuration = 100.0s;
> +constexpr Duration defaultMaxFrameDuration = 250.0s;

Reviewed-by: David Plowman <david.plowman@raspberrypi.com>

Thanks!
David

>
>  /*
>   * Determine the minimum allowable inter-frame duration to run the controller
> --
> 2.25.1
>

Patch
diff mbox series

diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
index 1c1e802a2cdc..8a8e9c0a52ab 100644
--- a/src/ipa/raspberrypi/raspberrypi.cpp
+++ b/src/ipa/raspberrypi/raspberrypi.cpp
@@ -61,7 +61,7 @@  using utils::Duration;
 constexpr double DefaultAnalogueGain = 1.0;
 constexpr Duration DefaultExposureTime = 20.0ms;
 constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;
-constexpr Duration defaultMaxFrameDuration = 100.0s;
+constexpr Duration defaultMaxFrameDuration = 250.0s;
 
 /*
  * Determine the minimum allowable inter-frame duration to run the controller