[libcamera-devel] libcamera: Add IMX258 sensor properties
diff mbox series

Message ID 20210527065829.35936-1-umang.jain@ideasonboard.com
State Accepted
Commit 388c4392c1527c7f7b485480496a1d4399c2ea9e
Headers show
Series
  • [libcamera-devel] libcamera: Add IMX258 sensor properties
Related show

Commit Message

Umang Jain May 27, 2021, 6:58 a.m. UTC
Brief specifications available at
https://www.sony-semicon.co.jp/products/common/pdf/ProductBrief_IMX258_20151015.pdf

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/libcamera/camera_sensor_properties.cpp | 3 +++
 1 file changed, 3 insertions(+)

Comments

Laurent Pinchart May 27, 2021, 9:14 a.m. UTC | #1
Hi Umang,

Thank you for the patch.

On Thu, May 27, 2021 at 12:28:29PM +0530, Umang Jain wrote:
> Brief specifications available at
> https://www.sony-semicon.co.jp/products/common/pdf/ProductBrief_IMX258_20151015.pdf
> 
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/camera_sensor_properties.cpp | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index 2a6e97f7..a2c04009 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -48,6 +48,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>  		{ "imx219", {
>  			.unitCellSize = { 1120, 1120 },
>  		} },
> +		{ "imx258", {
> +			.unitCellSize = { 1120, 1120 },
> +		} },
>  		{ "ov5670", {
>  			.unitCellSize = { 1120, 1120 },
>  		} },
Paul Elder June 4, 2021, 9:28 a.m. UTC | #2
Hi Umang,

On Thu, May 27, 2021 at 12:28:29PM +0530, Umang Jain wrote:
> Brief specifications available at
> https://www.sony-semicon.co.jp/products/common/pdf/ProductBrief_IMX258_20151015.pdf
> 
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/camera_sensor_properties.cpp | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index 2a6e97f7..a2c04009 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -48,6 +48,9 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>  		{ "imx219", {
>  			.unitCellSize = { 1120, 1120 },
>  		} },
> +		{ "imx258", {
> +			.unitCellSize = { 1120, 1120 },
> +		} },
>  		{ "ov5670", {
>  			.unitCellSize = { 1120, 1120 },
>  		} },
> -- 
> 2.29.2
>

Patch
diff mbox series

diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
index 2a6e97f7..a2c04009 100644
--- a/src/libcamera/camera_sensor_properties.cpp
+++ b/src/libcamera/camera_sensor_properties.cpp
@@ -48,6 +48,9 @@  const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
 		{ "imx219", {
 			.unitCellSize = { 1120, 1120 },
 		} },
+		{ "imx258", {
+			.unitCellSize = { 1120, 1120 },
+		} },
 		{ "ov5670", {
 			.unitCellSize = { 1120, 1120 },
 		} },