| Message ID | 20210526000855.17501-2-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, thank you for the patch. On Wed, May 26, 2021 at 9:09 AM Laurent Pinchart < laurent.pinchart@ideasonboard.com> wrote: > The <filesystem> header isn't needed in camera_hal_config.h, move its > inclusion to camera_hal_config.cpp. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > --- > src/android/camera_hal_config.cpp | 1 + > src/android/camera_hal_config.h | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/android/camera_hal_config.cpp > b/src/android/camera_hal_config.cpp > index 12d69a3f5f3c..d15df2e30c2c 100644 > --- a/src/android/camera_hal_config.cpp > +++ b/src/android/camera_hal_config.cpp > @@ -6,6 +6,7 @@ > */ > #include "camera_hal_config.h" > > +#include <filesystem> > #include <stdio.h> > #include <stdlib.h> > #include <string> > diff --git a/src/android/camera_hal_config.h > b/src/android/camera_hal_config.h > index 0555c6da2c20..97dc69c1def5 100644 > --- a/src/android/camera_hal_config.h > +++ b/src/android/camera_hal_config.h > @@ -7,7 +7,6 @@ > #ifndef __ANDROID_CAMERA_HAL_CONFIG_H__ > #define __ANDROID_CAMERA_HAL_CONFIG_H__ > > -#include <filesystem> > #include <map> > #include <string> > > -- > Regards, > > Laurent Pinchart > >
Hi Laurent, On Wed, May 26, 2021 at 03:08:54AM +0300, Laurent Pinchart wrote: > The <filesystem> header isn't needed in camera_hal_config.h, move its > inclusion to camera_hal_config.cpp. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > src/android/camera_hal_config.cpp | 1 + > src/android/camera_hal_config.h | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp > index 12d69a3f5f3c..d15df2e30c2c 100644 > --- a/src/android/camera_hal_config.cpp > +++ b/src/android/camera_hal_config.cpp > @@ -6,6 +6,7 @@ > */ > #include "camera_hal_config.h" > > +#include <filesystem> > #include <stdio.h> > #include <stdlib.h> > #include <string> > diff --git a/src/android/camera_hal_config.h b/src/android/camera_hal_config.h > index 0555c6da2c20..97dc69c1def5 100644 > --- a/src/android/camera_hal_config.h > +++ b/src/android/camera_hal_config.h > @@ -7,7 +7,6 @@ > #ifndef __ANDROID_CAMERA_HAL_CONFIG_H__ > #define __ANDROID_CAMERA_HAL_CONFIG_H__ > > -#include <filesystem> > #include <map> > #include <string> > > -- > Regards, > > Laurent Pinchart >
Hi Laurent, Thanks for your patch. On 2021-05-26 03:08:54 +0300, Laurent Pinchart wrote: > The <filesystem> header isn't needed in camera_hal_config.h, move its > inclusion to camera_hal_config.cpp. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/android/camera_hal_config.cpp | 1 + > src/android/camera_hal_config.h | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp > index 12d69a3f5f3c..d15df2e30c2c 100644 > --- a/src/android/camera_hal_config.cpp > +++ b/src/android/camera_hal_config.cpp > @@ -6,6 +6,7 @@ > */ > #include "camera_hal_config.h" > > +#include <filesystem> > #include <stdio.h> > #include <stdlib.h> > #include <string> > diff --git a/src/android/camera_hal_config.h b/src/android/camera_hal_config.h > index 0555c6da2c20..97dc69c1def5 100644 > --- a/src/android/camera_hal_config.h > +++ b/src/android/camera_hal_config.h > @@ -7,7 +7,6 @@ > #ifndef __ANDROID_CAMERA_HAL_CONFIG_H__ > #define __ANDROID_CAMERA_HAL_CONFIG_H__ > > -#include <filesystem> > #include <map> > #include <string> > > -- > Regards, > > Laurent Pinchart >
diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp index 12d69a3f5f3c..d15df2e30c2c 100644 --- a/src/android/camera_hal_config.cpp +++ b/src/android/camera_hal_config.cpp @@ -6,6 +6,7 @@ */ #include "camera_hal_config.h" +#include <filesystem> #include <stdio.h> #include <stdlib.h> #include <string> diff --git a/src/android/camera_hal_config.h b/src/android/camera_hal_config.h index 0555c6da2c20..97dc69c1def5 100644 --- a/src/android/camera_hal_config.h +++ b/src/android/camera_hal_config.h @@ -7,7 +7,6 @@ #ifndef __ANDROID_CAMERA_HAL_CONFIG_H__ #define __ANDROID_CAMERA_HAL_CONFIG_H__ -#include <filesystem> #include <map> #include <string>
The <filesystem> header isn't needed in camera_hal_config.h, move its inclusion to camera_hal_config.cpp. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/android/camera_hal_config.cpp | 1 + src/android/camera_hal_config.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)