[libcamera-devel,1/5] test: media_device: Move test definition

Message ID 20190101212947.28098-2-kieran.bingham@ideasonboard.com
State Accepted
Headers show
Series
  • test: Unit Test Improvements
Related show

Commit Message

Kieran Bingham Jan. 1, 2019, 9:29 p.m. UTC
The test definition for the media_device_test executable should be
located with the exectuable definition.

Move it to the meson.build of that test suite subdir.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 test/media_device/meson.build | 2 ++
 test/meson.build              | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Jacopo Mondi Jan. 2, 2019, 9:31 a.m. UTC | #1
Hi Kieran,
   thanks, I was not sure what the policy was,

On Tue, Jan 01, 2019 at 09:29:43PM +0000, Kieran Bingham wrote:
> The test definition for the media_device_test executable should be
> located with the exectuable definition.
>
> Move it to the meson.build of that test suite subdir.
>

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  test/media_device/meson.build | 2 ++
>  test/meson.build              | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/test/media_device/meson.build b/test/media_device/meson.build
> index a73644a08d6c..a7ebed102e24 100644
> --- a/test/media_device/meson.build
> +++ b/test/media_device/meson.build
> @@ -1,3 +1,5 @@
>  media_device_test = executable('media_device_test', 'media_device_test.cpp',
>                                 link_with : test_libraries,
>                                 include_directories : test_includes_internal)
> +
> +test('Media Device Test', media_device_test)
> diff --git a/test/meson.build b/test/meson.build
> index aabe79ddc442..3b7591ad9204 100644
> --- a/test/meson.build
> +++ b/test/meson.build
> @@ -24,4 +24,3 @@ subdir('media_device')
>
>  test('Initialisation test', test_init)
>  test('List Camera API tests', list)
> -test('Media Device Test', media_device_test)
> --
> 2.17.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/test/media_device/meson.build b/test/media_device/meson.build
index a73644a08d6c..a7ebed102e24 100644
--- a/test/media_device/meson.build
+++ b/test/media_device/meson.build
@@ -1,3 +1,5 @@ 
 media_device_test = executable('media_device_test', 'media_device_test.cpp',
                                link_with : test_libraries,
                                include_directories : test_includes_internal)
+
+test('Media Device Test', media_device_test)
diff --git a/test/meson.build b/test/meson.build
index aabe79ddc442..3b7591ad9204 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -24,4 +24,3 @@  subdir('media_device')
 
 test('Initialisation test', test_init)
 test('List Camera API tests', list)
-test('Media Device Test', media_device_test)