[libcamera-devel,v4,1/4] ipa: raspberrypi: Make CamHelper exposure methods virtual
diff mbox series

Message ID 20210427130844.11357-2-david.plowman@raspberrypi.com
State Superseded
Headers show
Series
  • Raspberry Pi: handle sensors more flexibly
Related show

Commit Message

David Plowman April 27, 2021, 1:08 p.m. UTC 
This allows derived classes to override them if they have any special
behaviours to implement. For instance if a particular camera mode
produces a different signal level to other modes, you might choose to
address that in the gain or exposure methods.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/ipa/raspberrypi/cam_helper.hpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch
diff mbox series 

diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp
index c3ed5362..618391e9 100644
--- a/src/ipa/raspberrypi/cam_helper.hpp
+++ b/src/ipa/raspberrypi/cam_helper.hpp
@@ -66,8 +66,8 @@  public:
 	virtual ~CamHelper();
 	void SetCameraMode(const CameraMode &mode);
 	MdParser &Parser() const { return *parser_; }
-	uint32_t ExposureLines(double exposure_us) const;
-	double Exposure(uint32_t exposure_lines) const; // in us
+	virtual uint32_t ExposureLines(double exposure_us) const;
+	virtual double Exposure(uint32_t exposure_lines) const; // in us
 	virtual uint32_t GetVBlanking(double &exposure_us, double minFrameDuration,
 				      double maxFrameDuration) const;
 	virtual uint32_t GainCode(double gain) const = 0;