[libcamera-devel,RFC,v2,01/12] android: camera_device: Fix typo in result metadata allocation error
diff mbox series

Message ID 20210422094102.371772-2-paul.elder@ideasonboard.com
State Accepted
Delegated to: Paul Elder
Headers show
Series
  • FULL hardware level fixes
Related show

Commit Message

Paul Elder April 22, 2021, 9:40 a.m. UTC 
Fix an error message typo s/static/result/.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
 src/android/camera_device.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart April 27, 2021, 4:12 a.m. UTC | #1 
Hi Paul,

Thank you for the patch.

On Thu, Apr 22, 2021 at 06:40:51PM +0900, Paul Elder wrote:
> Fix an error message typo s/static/result/.
> 
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/android/camera_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 2b8fd1e6..9336a027 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -2195,7 +2195,7 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons
>  	std::unique_ptr<CameraMetadata> resultMetadata =
>  		std::make_unique<CameraMetadata>(44, 166);
>  	if (!resultMetadata->isValid()) {
> -		LOG(HAL, Error) << "Failed to allocate static metadata";
> +		LOG(HAL, Error) << "Failed to allocate result metadata";
>  		return nullptr;
>  	}
>
Jacopo Mondi April 27, 2021, 7:40 a.m. UTC | #2 
Hi Paul,

On Thu, Apr 22, 2021 at 06:40:51PM +0900, Paul Elder wrote:
> Fix an error message typo s/static/result/.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
   j

> ---
>  src/android/camera_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 2b8fd1e6..9336a027 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -2195,7 +2195,7 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons
>  	std::unique_ptr<CameraMetadata> resultMetadata =
>  		std::make_unique<CameraMetadata>(44, 166);
>  	if (!resultMetadata->isValid()) {
> -		LOG(HAL, Error) << "Failed to allocate static metadata";
> +		LOG(HAL, Error) << "Failed to allocate result metadata";
>  		return nullptr;
>  	}
>
> --
> 2.27.0
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch
diff mbox series 

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index 2b8fd1e6..9336a027 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -2195,7 +2195,7 @@  CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons
 	std::unique_ptr<CameraMetadata> resultMetadata =
 		std::make_unique<CameraMetadata>(44, 166);
 	if (!resultMetadata->isValid()) {
-		LOG(HAL, Error) << "Failed to allocate static metadata";
+		LOG(HAL, Error) << "Failed to allocate result metadata";
 		return nullptr;
 	}