| Message ID | 20210418172712.61536-3-sebastian.fricke@posteo.net |
|---|---|
| State | Accepted |
| Commit | 446cb01d14470298f881c7bed4100c073f3ef835 |
| Headers | show |
| Series |
|
| Related | show |
Hi Sebastian, Thank you for the patch. On Sun, Apr 18, 2021 at 05:27:12PM +0000, Sebastian Fricke wrote: > Sensors provide embedded data buffers and not metadata buffers, > replace the incorrect term with the correct one. > > Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net> > Reviewed-by: David Plowman <david.plowman@raspberrypi.com> I still think embedded data is a type of metadata, but mentioning embedded data explicitly is good. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/ipa/raspberrypi/cam_helper.hpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp > index eaf73019..c3ed5362 100644 > --- a/src/ipa/raspberrypi/cam_helper.hpp > +++ b/src/ipa/raspberrypi/cam_helper.hpp > @@ -35,7 +35,7 @@ namespace RPiController { > // > // A method to query if the sensor outputs embedded data that can be parsed. > // > -// A parser to parse the metadata buffers provided by some sensors (for > +// A parser to parse the embedded data buffers provided by some sensors (for > // example, the imx219 does; the ov5647 doesn't). This allows us to know for > // sure the exposure and gain of the frame we're looking at. CamHelper > // provides methods for converting analogue gains to and from the sensor's
diff --git a/src/ipa/raspberrypi/cam_helper.hpp b/src/ipa/raspberrypi/cam_helper.hpp index eaf73019..c3ed5362 100644 --- a/src/ipa/raspberrypi/cam_helper.hpp +++ b/src/ipa/raspberrypi/cam_helper.hpp @@ -35,7 +35,7 @@ namespace RPiController { // // A method to query if the sensor outputs embedded data that can be parsed. // -// A parser to parse the metadata buffers provided by some sensors (for +// A parser to parse the embedded data buffers provided by some sensors (for // example, the imx219 does; the ov5647 doesn't). This allows us to know for // sure the exposure and gain of the frame we're looking at. CamHelper // provides methods for converting analogue gains to and from the sensor's