| Message ID | 20210406182335.85847-2-nfraprado@collabora.com |
|---|---|
| State | Accepted |
| Commit | 330ea9d946f97001593f65a08276c44076fb0f10 |
| Headers | show |
| Series |
|
| Related | show |
Hi Nícolas, Thanks for your work. On 2021-04-06 15:23:33 -0300, Nícolas F. R. A. Prado wrote: > The IPA should be stopped before stopping the streams in order to avoid > a "No BufferCache available to queue" issue. > > This issue happened while running lc-compliance. > > Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index 037573270d1e..c122c9be2afd 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -827,6 +827,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera) > > isp_->setFrameStartEnabled(false); > > + data->ipa_->stop(); > + > selfPath_.stop(); > mainPath_.stop(); > > @@ -840,8 +842,6 @@ void PipelineHandlerRkISP1::stop(Camera *camera) > LOG(RkISP1, Warning) > << "Failed to stop parameters for " << camera->id(); > > - data->ipa_->stop(); > - > data->frameInfo_.clear(); > > freeBuffers(camera); > -- > 2.31.1 >
Hi Nicolas, On 06/04/2021 19:23, Nícolas F. R. A. Prado wrote: > The IPA should be stopped before stopping the streams in order to avoid > a "No BufferCache available to queue" issue. > > This issue happened while running lc-compliance. > > Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index 037573270d1e..c122c9be2afd 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -827,6 +827,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera) > > isp_->setFrameStartEnabled(false); > > + data->ipa_->stop(); > + > selfPath_.stop(); > mainPath_.stop(); > > @@ -840,8 +842,6 @@ void PipelineHandlerRkISP1::stop(Camera *camera) > LOG(RkISP1, Warning) > << "Failed to stop parameters for " << camera->id(); > > - data->ipa_->stop(); > - > data->frameInfo_.clear(); > > freeBuffers(camera); >
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 037573270d1e..c122c9be2afd 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -827,6 +827,8 @@ void PipelineHandlerRkISP1::stop(Camera *camera) isp_->setFrameStartEnabled(false); + data->ipa_->stop(); + selfPath_.stop(); mainPath_.stop(); @@ -840,8 +842,6 @@ void PipelineHandlerRkISP1::stop(Camera *camera) LOG(RkISP1, Warning) << "Failed to stop parameters for " << camera->id(); - data->ipa_->stop(); - data->frameInfo_.clear(); freeBuffers(camera);
The IPA should be stopped before stopping the streams in order to avoid a "No BufferCache available to queue" issue. This issue happened while running lc-compliance. Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)