[libcamera-devel,v2,6/6] android: soraka: Add camera HAL configuration

11770 diff mbox series

Add camera HAL configuration file for IPU3 Soraka.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/android/data/soraka/camera_hal.yaml | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 src/android/data/soraka/camera_hal.yaml

Hi Jacopo,

Thank you for the patch.

On Mon, Mar 29, 2021 at 05:28:07PM +0200, Jacopo Mondi wrote:
> Add camera HAL configuration file for IPU3 Soraka.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  src/android/data/soraka/camera_hal.yaml | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 src/android/data/soraka/camera_hal.yaml
> 
> diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml
> new file mode 100644
> index 000000000000..59d1cdedb2c8
> --- /dev/null
> +++ b/src/android/data/soraka/camera_hal.yaml
> @@ -0,0 +1,13 @@
> +manufacturer: Google
> +model: Soraka
> +
> +cameras:
> +  "\\_SB_.PCI0.I2C4.CAM1":
> +    model: "ov5670"

No need for quotes for model and location, same below.

> +    location: "front"
> +    rotation: 0
> +
> +  "\\_SB_.PCI0.I2C2.CAM0":
> +    model: "ov13858"
> +    location: "back"
> +    rotation: 0

I'm sure we'll bikeshed lots of topics, including the name of the
configuration file, and possibly the option of storing data for multiple
devices in a single file, but that's for later.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Hi Jacopo. Thanks for the patch.

On Tue, Mar 30, 2021 at 9:15 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Mon, Mar 29, 2021 at 05:28:07PM +0200, Jacopo Mondi wrote:
> > Add camera HAL configuration file for IPU3 Soraka.
> >
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >  src/android/data/soraka/camera_hal.yaml | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >  create mode 100644 src/android/data/soraka/camera_hal.yaml
> >
> > diff --git a/src/android/data/soraka/camera_hal.yaml b/src/android/data/soraka/camera_hal.yaml
> > new file mode 100644
> > index 000000000000..59d1cdedb2c8
> > --- /dev/null
> > +++ b/src/android/data/soraka/camera_hal.yaml
> > @@ -0,0 +1,13 @@
> > +manufacturer: Google
> > +model: Soraka
> > +
> > +cameras:
> > +  "\\_SB_.PCI0.I2C4.CAM1":
> > +    model: "ov5670"
>
> No need for quotes for model and location, same below.
>
> > +    location: "front"
> > +    rotation: 0
> > +
> > +  "\\_SB_.PCI0.I2C2.CAM0":
> > +    model: "ov13858"
> > +    location: "back"
> > +    rotation: 0
>
> I'm sure we'll bikeshed lots of topics, including the name of the
> configuration file, and possibly the option of storing data for multiple
> devices in a single file, but that's for later.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>

Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

> --
> Regards,
>
> Laurent Pinchart
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel