| Message ID | 20210328125906.25461-1-sebastian.fricke@posteo.net |
|---|---|
| State | Accepted |
| Commit | 3d3e6fcdb92a7d337f3e5472f0f989f625f8985e |
| Headers | show |
| Series |
|
| Related | show |
Hi Sebastian, Thank you for the patch. On Sun, Mar 28, 2021 at 02:59:07PM +0200, Sebastian Fricke wrote: > s/Will need to/We'll need to/ > > Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > index 2cac802c..378a5227 100644 > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > @@ -1141,7 +1141,7 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera) > > /* > * Decide how many internal buffers to allocate. For now, simply look > - * at how many external buffers will be provided. Will need to improve > + * at how many external buffers will be provided. We'll need to improve > * this logic. However, we really must have all streams allocate the same > * number of buffers to simplify error handling in queueRequestDevice(). > */
Hi Sebastian, Thank you for your patch. On Sun, 28 Mar 2021 at 13:59, Sebastian Fricke <sebastian.fricke@posteo.net> wrote: > s/Will need to/We'll need to/ > > Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net> > s/raspberryPi/raspberrypi/ Apart from that: Reviewed-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > index 2cac802c..378a5227 100644 > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp > @@ -1141,7 +1141,7 @@ int PipelineHandlerRPi::prepareBuffers(Camera > *camera) > > /* > * Decide how many internal buffers to allocate. For now, simply > look > - * at how many external buffers will be provided. Will need to > improve > + * at how many external buffers will be provided. We'll need to > improve > * this logic. However, we really must have all streams allocate > the same > * number of buffers to simplify error handling in > queueRequestDevice(). > */ > -- > 2.25.1 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel >
diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 2cac802c..378a5227 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1141,7 +1141,7 @@ int PipelineHandlerRPi::prepareBuffers(Camera *camera) /* * Decide how many internal buffers to allocate. For now, simply look - * at how many external buffers will be provided. Will need to improve + * at how many external buffers will be provided. We'll need to improve * this logic. However, we really must have all streams allocate the same * number of buffers to simplify error handling in queueRequestDevice(). */
s/Will need to/We'll need to/ Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net> --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)