[libcamera-devel,10/11] libcamera: pipeline: ipu3: frames: Fail if the FrameInfo can't be found
diff mbox series

Message ID 20210325134231.1400051-1-kieran.bingham@ideasonboard.com
State Superseded
Delegated to: Kieran Bingham
Headers show
Series
  • [libcamera-devel,v3,01/11] utils: ipc: proxy: Track IPA with a state machine
Related show

Commit Message

Kieran Bingham March 25, 2021, 1:42 p.m. UTC
The FrameInfo structure associates the data sent to the IPA
and is essential for handling events.

If it can not be found, this is a fatal error which must be fixed.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

---
v3:
 - Make all occurrences of failing to find a frame info fatal.
---
 src/libcamera/pipeline/ipu3/frames.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Patch
diff mbox series

diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp
index e8eb1c5103e8..34ab4be6711b 100644
--- a/src/libcamera/pipeline/ipu3/frames.cpp
+++ b/src/libcamera/pipeline/ipu3/frames.cpp
@@ -115,7 +115,8 @@  IPU3Frames::Info *IPU3Frames::find(unsigned int id)
 	if (itInfo != frameInfo_.end())
 		return itInfo->second.get();
 
-	LOG(IPU3, Error) << "Can't find tracking informaton for frame " << id;
+	LOG(IPU3, Fatal) << "Can't find tracking informaton for frame " << id;
+
 	return nullptr;
 }
 
@@ -133,7 +134,8 @@  IPU3Frames::Info *IPU3Frames::find(FrameBuffer *buffer)
 			return info;
 	}
 
-	LOG(IPU3, Error) << "Can't find tracking informaton from buffer";
+	LOG(IPU3, Fatal) << "Can't find tracking informaton from buffer";
+
 	return nullptr;
 }