| Message ID | 20190101212328.18361-2-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On 01/01/2019 21:23, Laurent Pinchart wrote: > The function is useful as a public API, make it public. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Not really my code here, but seem reasonable to me. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/include/media_device.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/libcamera/include/media_device.h b/src/libcamera/include/media_device.h > index 74a67c81398a..fd1e12d1bbcb 100644 > --- a/src/libcamera/include/media_device.h > +++ b/src/libcamera/include/media_device.h > @@ -32,7 +32,9 @@ public: > > const std::string driver() const { return driver_; } > const std::string devnode() const { return devnode_; } > + > const std::vector<MediaEntity *> &entities() const { return entities_; } > + MediaEntity *getEntityByName(const std::string &name); > > private: > std::string driver_; > @@ -46,7 +48,6 @@ private: > void clear(); > > std::vector<MediaEntity *> entities_; > - MediaEntity *getEntityByName(const std::string &name); > > bool populateEntities(const struct media_v2_topology &topology); > bool populatePads(const struct media_v2_topology &topology); >
diff --git a/src/libcamera/include/media_device.h b/src/libcamera/include/media_device.h index 74a67c81398a..fd1e12d1bbcb 100644 --- a/src/libcamera/include/media_device.h +++ b/src/libcamera/include/media_device.h @@ -32,7 +32,9 @@ public: const std::string driver() const { return driver_; } const std::string devnode() const { return devnode_; } + const std::vector<MediaEntity *> &entities() const { return entities_; } + MediaEntity *getEntityByName(const std::string &name); private: std::string driver_; @@ -46,7 +48,6 @@ private: void clear(); std::vector<MediaEntity *> entities_; - MediaEntity *getEntityByName(const std::string &name); bool populateEntities(const struct media_v2_topology &topology); bool populatePads(const struct media_v2_topology &topology);
The function is useful as a public API, make it public. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/include/media_device.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)