[libcamera-devel,1/7] libcamera: List dependency for Android Camera3 HAL
diff mbox series

Message ID 20210324112527.63701-2-jacopo@jmondi.org
State Superseded
Delegated to: Jacopo Mondi
Headers show
Series
  • android: Add support for HAL configuration file
Related show

Commit Message

Jacopo Mondi March 24, 2021, 11:25 a.m. UTC
Add to the README.rst file the list of depdendencies for the
Android Camera3 HAL.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 README.rst | 3 +++
 1 file changed, 3 insertions(+)

Comments

Hirokazu Honda March 25, 2021, 6:25 a.m. UTC | #1
Hi Jacopo, thanks for the patch.

On Wed, Mar 24, 2021 at 8:25 PM Jacopo Mondi <jacopo@jmondi.org> wrote:
>
> Add to the README.rst file the list of depdendencies for the
> Android Camera3 HAL.
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

> ---
>  README.rst | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/README.rst b/README.rst
> index 1427c7143fa6..28c33871140a 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -87,6 +87,9 @@ for qcam: [optional]
>  for tracing with lttng: [optional]
>          liblttng-ust-dev python3-jinja2 lttng-tools
>
> +for Android Camera3 HAL: [optional]

nit: Perhaps, for android: [optional]?
For the consistency with others, like cam and qcam.
> +        libexif libjpeg
> +

Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

>  Using GStreamer plugin
>  ~~~~~~~~~~~~~~~~~~~~~~
>
> --
> 2.30.0
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Laurent Pinchart March 26, 2021, 3:06 a.m. UTC | #2
Hi Jacopo,

Thank you for the patch.

On Wed, Mar 24, 2021 at 12:25:21PM +0100, Jacopo Mondi wrote:
> Add to the README.rst file the list of depdendencies for the
> Android Camera3 HAL.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  README.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/README.rst b/README.rst
> index 1427c7143fa6..28c33871140a 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -87,6 +87,9 @@ for qcam: [optional]
>  for tracing with lttng: [optional]
>          liblttng-ust-dev python3-jinja2 lttng-tools
>  
> +for Android Camera3 HAL: [optional]
> +        libexif libjpeg
> +
>  Using GStreamer plugin
>  ~~~~~~~~~~~~~~~~~~~~~~
>
Paul Elder March 26, 2021, 6:25 a.m. UTC | #3
Hi Jacopo,

On Wed, Mar 24, 2021 at 12:25:21PM +0100, Jacopo Mondi wrote:
> Add to the README.rst file the list of depdendencies for the
> Android Camera3 HAL.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
>  README.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/README.rst b/README.rst
> index 1427c7143fa6..28c33871140a 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -87,6 +87,9 @@ for qcam: [optional]
>  for tracing with lttng: [optional]
>          liblttng-ust-dev python3-jinja2 lttng-tools
>  
> +for Android Camera3 HAL: [optional]
> +        libexif libjpeg
> +
>  Using GStreamer plugin
>  ~~~~~~~~~~~~~~~~~~~~~~
>  
> -- 
> 2.30.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch
diff mbox series

diff --git a/README.rst b/README.rst
index 1427c7143fa6..28c33871140a 100644
--- a/README.rst
+++ b/README.rst
@@ -87,6 +87,9 @@  for qcam: [optional]
 for tracing with lttng: [optional]
         liblttng-ust-dev python3-jinja2 lttng-tools
 
+for Android Camera3 HAL: [optional]
+        libexif libjpeg
+
 Using GStreamer plugin
 ~~~~~~~~~~~~~~~~~~~~~~