[libcamera-devel] README: Update tracing dependancies
diff mbox series

Message ID 20210302152614.106017-1-kieran.bingham@ideasonboard.com
State Accepted
Commit 3620f25c61cfaf6db3e5128b59e26f8d432c95fd
Headers show
Series
  • [libcamera-devel] README: Update tracing dependancies
Related show

Commit Message

Kieran Bingham March 2, 2021, 3:26 p.m. UTC
The packages required for tracing libcamera projects were incorrectly
specified.

Update with the correct prefix for the dev package on liblttng-ust-dev
and also provide the lttng-tools package which provides the utilities
required to handle tracing.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 README.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart March 2, 2021, 3:27 p.m. UTC | #1
Hi Kieran,

Thank you for the patch.

On Tue, Mar 02, 2021 at 03:26:14PM +0000, Kieran Bingham wrote:
> The packages required for tracing libcamera projects were incorrectly
> specified.
> 
> Update with the correct prefix for the dev package on liblttng-ust-dev
> and also provide the lttng-tools package which provides the utilities
> required to handle tracing.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  README.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README.rst b/README.rst
> index 08bfd5ad192a..b48455ab4e67 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -85,7 +85,7 @@ for qcam: [optional]
>  	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev
>  
>  for tracing with lttng: [optional]
> -        lttng-ust-dev python3-jinja2
> +        liblttng-ust-dev python3-jinja2 lttng-tools
>  
>  Using GStreamer plugin
>  ~~~~~~~~~~~~~~~~~~~~~~
Paul Elder March 3, 2021, 12:20 a.m. UTC | #2
Hi Kieran,

On Tue, Mar 02, 2021 at 03:26:14PM +0000, Kieran Bingham wrote:
> The packages required for tracing libcamera projects were incorrectly
> specified.
> 
> Update with the correct prefix for the dev package on liblttng-ust-dev
> and also provide the lttng-tools package which provides the utilities
> required to handle tracing.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  README.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README.rst b/README.rst
> index 08bfd5ad192a..b48455ab4e67 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -85,7 +85,7 @@ for qcam: [optional]
>  	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev
>  
>  for tracing with lttng: [optional]
> -        lttng-ust-dev python3-jinja2
> +        liblttng-ust-dev python3-jinja2 lttng-tools
>  
>  Using GStreamer plugin
>  ~~~~~~~~~~~~~~~~~~~~~~
> -- 
> 2.25.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Laurent Pinchart March 3, 2021, 6:44 a.m. UTC | #3
On Tue, Mar 02, 2021 at 05:27:59PM +0200, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.

And maybe s/dependancies/dependencies/ in the subject line ?

> On Tue, Mar 02, 2021 at 03:26:14PM +0000, Kieran Bingham wrote:
> > The packages required for tracing libcamera projects were incorrectly
> > specified.
> > 
> > Update with the correct prefix for the dev package on liblttng-ust-dev
> > and also provide the lttng-tools package which provides the utilities
> > required to handle tracing.
> > 
> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> > ---
> >  README.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/README.rst b/README.rst
> > index 08bfd5ad192a..b48455ab4e67 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -85,7 +85,7 @@ for qcam: [optional]
> >  	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev
> >  
> >  for tracing with lttng: [optional]
> > -        lttng-ust-dev python3-jinja2
> > +        liblttng-ust-dev python3-jinja2 lttng-tools
> >  
> >  Using GStreamer plugin
> >  ~~~~~~~~~~~~~~~~~~~~~~

Patch
diff mbox series

diff --git a/README.rst b/README.rst
index 08bfd5ad192a..b48455ab4e67 100644
--- a/README.rst
+++ b/README.rst
@@ -85,7 +85,7 @@  for qcam: [optional]
 	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev
 
 for tracing with lttng: [optional]
-        lttng-ust-dev python3-jinja2
+        liblttng-ust-dev python3-jinja2 lttng-tools
 
 Using GStreamer plugin
 ~~~~~~~~~~~~~~~~~~~~~~