[libcamera-devel,v2,2/2] android: camera_device: Set the camera location to Front if External
diff mbox series

Message ID 20210222080112.72521-3-paul.elder@ideasonboard.com
State Accepted
Headers show
Series
  • Fix camera location
Related show

Commit Message

Paul Elder Feb. 22, 2021, 8:01 a.m. UTC 
Our android HAL implementation currently does not support external
cameras, so if the camera location property is external, set it to
front.

This allows the following CTS test to pass:
- android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

---
No change in v2
---
 src/android/camera_device.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Patch
diff mbox series 

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index 1e2a5b5f..16cb8c6d 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -405,7 +405,11 @@  int CameraDevice::initialize()
 			facing_ = CAMERA_FACING_BACK;
 			break;
 		case properties::CameraLocationExternal:
-			facing_ = CAMERA_FACING_EXTERNAL;
+			/*
+			 * \todo Set this to EXTERNAL once we support
+			 * HARDWARE_LEVEL_EXTERNAL
+			 */
+			facing_ = CAMERA_FACING_FRONT;
 			break;
 		}
 	}