| Message ID | 20190426150155.18652-5-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 1ec73e9ad5008824c80e3b7577437699e9bac898 |
| Headers | show |
| Series |
|
| Related | show |
On 26/04/2019 17:01, Laurent Pinchart wrote: > Several overridden virtual functions are not marked with override. Fix > it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I'll have to remember to add this to the PipelineHandlerRPi too... Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- > src/libcamera/pipeline/uvcvideo.cpp | 2 +- > src/libcamera/pipeline/vimc.cpp | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index 2c2929207d35..97a309207621 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -167,7 +167,7 @@ public: > > int queueRequest(Camera *camera, Request *request) override; > > - bool match(DeviceEnumerator *enumerator); > + bool match(DeviceEnumerator *enumerator) override; > > private: > class IPU3CameraData : public CameraData > diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp > index b8f634d88b46..2f9b5e0fdc08 100644 > --- a/src/libcamera/pipeline/uvcvideo.cpp > +++ b/src/libcamera/pipeline/uvcvideo.cpp > @@ -42,7 +42,7 @@ public: > > int queueRequest(Camera *camera, Request *request) override; > > - bool match(DeviceEnumerator *enumerator); > + bool match(DeviceEnumerator *enumerator) override; > > private: > class UVCCameraData : public CameraData > diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp > index 22449e47bc2d..f70b4d3c6bab 100644 > --- a/src/libcamera/pipeline/vimc.cpp > +++ b/src/libcamera/pipeline/vimc.cpp > @@ -42,7 +42,7 @@ public: > > int queueRequest(Camera *camera, Request *request) override; > > - bool match(DeviceEnumerator *enumerator); > + bool match(DeviceEnumerator *enumerator) override; > > private: > class VimcCameraData : public CameraData >
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 2c2929207d35..97a309207621 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -167,7 +167,7 @@ public: int queueRequest(Camera *camera, Request *request) override; - bool match(DeviceEnumerator *enumerator); + bool match(DeviceEnumerator *enumerator) override; private: class IPU3CameraData : public CameraData diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp index b8f634d88b46..2f9b5e0fdc08 100644 --- a/src/libcamera/pipeline/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo.cpp @@ -42,7 +42,7 @@ public: int queueRequest(Camera *camera, Request *request) override; - bool match(DeviceEnumerator *enumerator); + bool match(DeviceEnumerator *enumerator) override; private: class UVCCameraData : public CameraData diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp index 22449e47bc2d..f70b4d3c6bab 100644 --- a/src/libcamera/pipeline/vimc.cpp +++ b/src/libcamera/pipeline/vimc.cpp @@ -42,7 +42,7 @@ public: int queueRequest(Camera *camera, Request *request) override; - bool match(DeviceEnumerator *enumerator); + bool match(DeviceEnumerator *enumerator) override; private: class VimcCameraData : public CameraData
Several overridden virtual functions are not marked with override. Fix it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- src/libcamera/pipeline/uvcvideo.cpp | 2 +- src/libcamera/pipeline/vimc.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)