[libcamera-devel,11/20] libcamera: pipeline: simple: Drop unused members of configuration
diff mbox series

Message ID 20210131224702.8838-12-laurent.pinchart@ideasonboard.com
State Accepted
Delegated to: Laurent Pinchart
Headers show
Series
  • [libcamera-devel,01/20] libcamera: pipeline: simple: Manage converter with std::unique_ptr<>
Related show

Commit Message

Laurent Pinchart Jan. 31, 2021, 10:46 p.m. UTC 
The SimpleCameraConfiguration class has a sensorFormat_ member variable
and a corresponding accessor that are never used. Drop them.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/pipeline/simple/simple.cpp | 3 ---
 1 file changed, 3 deletions(-)

Comments

Kieran Bingham March 1, 2021, 8:12 p.m. UTC | #1 
On 31/01/2021 22:46, Laurent Pinchart wrote:
> The SimpleCameraConfiguration class has a sensorFormat_ member variable
> and a corresponding accessor that are never used. Drop them.
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/libcamera/pipeline/simple/simple.cpp | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 390c87ba74d8..f072e0f1fa81 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -94,8 +94,6 @@ public:
>  
>  	Status validate() override;
>  
> -	const V4L2SubdeviceFormat &sensorFormat() { return sensorFormat_; }
> -
>  	bool needConversion() const { return needConversion_; }
>  
>  private:
> @@ -107,7 +105,6 @@ private:
>  	std::shared_ptr<Camera> camera_;
>  	const SimpleCameraData *data_;
>  
> -	V4L2SubdeviceFormat sensorFormat_;
>  	bool needConversion_;
>  };
>  
>
Paul Elder March 2, 2021, 12:34 a.m. UTC | #2 
Hi Laurent,

On Mon, Feb 01, 2021 at 12:46:53AM +0200, Laurent Pinchart wrote:
> The SimpleCameraConfiguration class has a sensorFormat_ member variable
> and a corresponding accessor that are never used. Drop them.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/pipeline/simple/simple.cpp | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index 390c87ba74d8..f072e0f1fa81 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -94,8 +94,6 @@ public:
>  
>  	Status validate() override;
>  
> -	const V4L2SubdeviceFormat &sensorFormat() { return sensorFormat_; }
> -
>  	bool needConversion() const { return needConversion_; }
>  
>  private:
> @@ -107,7 +105,6 @@ private:
>  	std::shared_ptr<Camera> camera_;
>  	const SimpleCameraData *data_;
>  
> -	V4L2SubdeviceFormat sensorFormat_;
>  	bool needConversion_;
>  };
>  
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
index 390c87ba74d8..f072e0f1fa81 100644
--- a/src/libcamera/pipeline/simple/simple.cpp
+++ b/src/libcamera/pipeline/simple/simple.cpp
@@ -94,8 +94,6 @@  public:
 
 	Status validate() override;
 
-	const V4L2SubdeviceFormat &sensorFormat() { return sensorFormat_; }
-
 	bool needConversion() const { return needConversion_; }
 
 private:
@@ -107,7 +105,6 @@  private:
 	std::shared_ptr<Camera> camera_;
 	const SimpleCameraData *data_;
 
-	V4L2SubdeviceFormat sensorFormat_;
 	bool needConversion_;
 };