| Message ID | 20210122102211.12768-6-david.plowman@raspberrypi.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi David, Thank you for the patch. On Fri, Jan 22, 2021 at 10:22:11AM +0000, David Plowman wrote: > Signed-off-by: David Plowman <david.plowman@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/ipa/raspberrypi/controller/algorithm.hpp | 1 - > src/ipa/raspberrypi/controller/logging.hpp | 30 -------------------- > 2 files changed, 31 deletions(-) > delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp > > diff --git a/src/ipa/raspberrypi/controller/algorithm.hpp b/src/ipa/raspberrypi/controller/algorithm.hpp > index 17423f23..e9b040c7 100644 > --- a/src/ipa/raspberrypi/controller/algorithm.hpp > +++ b/src/ipa/raspberrypi/controller/algorithm.hpp > @@ -14,7 +14,6 @@ > #include <map> > #include <atomic> > > -#include "logging.hpp" > #include "controller.hpp" > > #include <boost/property_tree/ptree.hpp> > diff --git a/src/ipa/raspberrypi/controller/logging.hpp b/src/ipa/raspberrypi/controller/logging.hpp > deleted file mode 100644 > index f0d306b6..00000000 > --- a/src/ipa/raspberrypi/controller/logging.hpp > +++ /dev/null > @@ -1,30 +0,0 @@ > -/* SPDX-License-Identifier: BSD-2-Clause */ > -/* > - * Copyright (C) 2019-2020, Raspberry Pi (Trading) Limited > - * > - * logging.hpp - logging macros > - */ > -#pragma once > - > -#include <iostream> > - > -#ifndef RPI_LOGGING_ENABLE > -#define RPI_LOGGING_ENABLE 0 > -#endif > - > -#ifndef RPI_WARNING_ENABLE > -#define RPI_WARNING_ENABLE 1 > -#endif > - > -#define RPI_LOG(stuff) \ > - do { \ > - if (RPI_LOGGING_ENABLE) \ > - std::cout << __FUNCTION__ << ": " << stuff << "\n"; \ > - } while (0) > - > -#define RPI_WARN(stuff) \ > - do { \ > - if (RPI_WARNING_ENABLE) \ > - std::cout << __FUNCTION__ << " ***WARNING*** " \ > - << stuff << "\n"; \ > - } while (0)
diff --git a/src/ipa/raspberrypi/controller/algorithm.hpp b/src/ipa/raspberrypi/controller/algorithm.hpp index 17423f23..e9b040c7 100644 --- a/src/ipa/raspberrypi/controller/algorithm.hpp +++ b/src/ipa/raspberrypi/controller/algorithm.hpp @@ -14,7 +14,6 @@ #include <map> #include <atomic> -#include "logging.hpp" #include "controller.hpp" #include <boost/property_tree/ptree.hpp> diff --git a/src/ipa/raspberrypi/controller/logging.hpp b/src/ipa/raspberrypi/controller/logging.hpp deleted file mode 100644 index f0d306b6..00000000 --- a/src/ipa/raspberrypi/controller/logging.hpp +++ /dev/null @@ -1,30 +0,0 @@ -/* SPDX-License-Identifier: BSD-2-Clause */ -/* - * Copyright (C) 2019-2020, Raspberry Pi (Trading) Limited - * - * logging.hpp - logging macros - */ -#pragma once - -#include <iostream> - -#ifndef RPI_LOGGING_ENABLE -#define RPI_LOGGING_ENABLE 0 -#endif - -#ifndef RPI_WARNING_ENABLE -#define RPI_WARNING_ENABLE 1 -#endif - -#define RPI_LOG(stuff) \ - do { \ - if (RPI_LOGGING_ENABLE) \ - std::cout << __FUNCTION__ << ": " << stuff << "\n"; \ - } while (0) - -#define RPI_WARN(stuff) \ - do { \ - if (RPI_WARNING_ENABLE) \ - std::cout << __FUNCTION__ << " ***WARNING*** " \ - << stuff << "\n"; \ - } while (0)
Signed-off-by: David Plowman <david.plowman@raspberrypi.com> --- src/ipa/raspberrypi/controller/algorithm.hpp | 1 - src/ipa/raspberrypi/controller/logging.hpp | 30 -------------------- 2 files changed, 31 deletions(-) delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp