| Message ID | 20210118114624.13240-1-jacopo@jmondi.org |
|---|---|
| State | Accepted |
| Commit | fc2835888172d090e48900262b1e4c50d1074061 |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, On 18/01/2021 11:46, Jacopo Mondi wrote: > Reorder the introductory section of the sensor driver requirements > document to match the expected English language syntax. > > Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Sorry - must have missed that there were two patches here not one. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> I think these can both be pushed, they were only minor review comments from a previous documentation patch. -- Kieran > --- > Documentation/sensor_driver_requirements.rst | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst > index 0e658aaa03b5..8cd24c15ca63 100644 > --- a/Documentation/sensor_driver_requirements.rst > +++ b/Documentation/sensor_driver_requirements.rst > @@ -6,15 +6,15 @@ Sensor Driver Requirements > ========================== > > libcamera handles imaging devices in the CameraSensor class and defines > -through its API a consistent interface towards other library components. > +a consistent interface through its API towards other library components. > > The CameraSensor class uses the V4L2 subdev kernel API to interface with the > camera sensor through one or multiple sub-devices exposed in userspace by > the sensor driver. > > -In order for libcamera to be fully operational and provide to applications and > -pipeline handlers all the required information to interface with the camera > -sensor, a set of mandatory and optional features the driver has to support > +In order for libcamera to be fully operational and provide all the required > +information to interface with the camera sensor to applications and pipeline > +handlers, a set of mandatory and optional features the driver has to support > has been defined. > > Mandatory Requirements >
diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst index 0e658aaa03b5..8cd24c15ca63 100644 --- a/Documentation/sensor_driver_requirements.rst +++ b/Documentation/sensor_driver_requirements.rst @@ -6,15 +6,15 @@ Sensor Driver Requirements ========================== libcamera handles imaging devices in the CameraSensor class and defines -through its API a consistent interface towards other library components. +a consistent interface through its API towards other library components. The CameraSensor class uses the V4L2 subdev kernel API to interface with the camera sensor through one or multiple sub-devices exposed in userspace by the sensor driver. -In order for libcamera to be fully operational and provide to applications and -pipeline handlers all the required information to interface with the camera -sensor, a set of mandatory and optional features the driver has to support +In order for libcamera to be fully operational and provide all the required +information to interface with the camera sensor to applications and pipeline +handlers, a set of mandatory and optional features the driver has to support has been defined. Mandatory Requirements
Reorder the introductory section of the sensor driver requirements document to match the expected English language syntax. Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- Documentation/sensor_driver_requirements.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)