| Message ID | 20201208034234.2501401-1-hiroh@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Hiro, On Tue, Dec 08, 2020 at 03:42:31AM +0000, Hirokazu Honda wrote: > Camera3StreamConfig is a new class to store camera3_stream and > types with associated StreamConfiguration. > > Signed-off-by: Hirokazu Honda <hiroh@chromium.org> Please retain tags received on previous versions, or if you drop them intentionally feel free to mention it explicitly. Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > src/android/camera_device.cpp | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp > index 675af570..09269d95 100644 > --- a/src/android/camera_device.cpp > +++ b/src/android/camera_device.cpp > @@ -128,6 +128,18 @@ const std::map<int, const Camera3Format> camera3FormatsMap = { > }, > }; > > +/* > + * \struct Camera3StreamConfig > + * \brief Data to store StreamConfiguration associated with camera3_stream(s). > + * \var streams List of streams requested by Android HAL client. > + * \var types List of CameraStream::Type associated with streams. > + * \var config StreamConfiguration for streams. > + */ > +struct Camera3StreamConfig { > + std::vector<camera3_stream_t*> streams; > + std::vector<CameraStream::Type> types; > + StreamConfiguration config; > +}; > } /* namespace */ > > LOG_DECLARE_CATEGORY(HAL) > -- > 2.29.2.576.ga3fc446d84-goog
Hi Jacopo, On Wed, Dec 9, 2020 at 3:38 AM Jacopo Mondi <jacopo@jmondi.org> wrote: > > Hi Hiro, > > On Tue, Dec 08, 2020 at 03:42:31AM +0000, Hirokazu Honda wrote: > > Camera3StreamConfig is a new class to store camera3_stream and > > types with associated StreamConfiguration. > > > > Signed-off-by: Hirokazu Honda <hiroh@chromium.org> > > Please retain tags received on previous versions, or if you drop them > intentionally feel free to mention it explicitly. > > Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> > Thanks for reviewing. I definitely forgot adding it sorry. Regards, -Hiro > Thanks > j > > > --- > > src/android/camera_device.cpp | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp > > index 675af570..09269d95 100644 > > --- a/src/android/camera_device.cpp > > +++ b/src/android/camera_device.cpp > > @@ -128,6 +128,18 @@ const std::map<int, const Camera3Format> camera3FormatsMap = { > > }, > > }; > > > > +/* > > + * \struct Camera3StreamConfig > > + * \brief Data to store StreamConfiguration associated with camera3_stream(s). > > + * \var streams List of streams requested by Android HAL client. > > + * \var types List of CameraStream::Type associated with streams. > > + * \var config StreamConfiguration for streams. > > + */ > > +struct Camera3StreamConfig { > > + std::vector<camera3_stream_t*> streams; > > + std::vector<CameraStream::Type> types; > > + StreamConfiguration config; > > +}; > > } /* namespace */ > > > > LOG_DECLARE_CATEGORY(HAL) > > -- > > 2.29.2.576.ga3fc446d84-goog
diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp index 675af570..09269d95 100644 --- a/src/android/camera_device.cpp +++ b/src/android/camera_device.cpp @@ -128,6 +128,18 @@ const std::map<int, const Camera3Format> camera3FormatsMap = { }, }; +/* + * \struct Camera3StreamConfig + * \brief Data to store StreamConfiguration associated with camera3_stream(s). + * \var streams List of streams requested by Android HAL client. + * \var types List of CameraStream::Type associated with streams. + * \var config StreamConfiguration for streams. + */ +struct Camera3StreamConfig { + std::vector<camera3_stream_t*> streams; + std::vector<CameraStream::Type> types; + StreamConfiguration config; +}; } /* namespace */ LOG_DECLARE_CATEGORY(HAL)
Camera3StreamConfig is a new class to store camera3_stream and types with associated StreamConfiguration. Signed-off-by: Hirokazu Honda <hiroh@chromium.org> --- src/android/camera_device.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) -- 2.29.2.576.ga3fc446d84-goog