[libcamera-devel,v5,10/23] ipa: raspberrypi: meson: Add dependency on generated headers
diff mbox series

Message ID 20201205103106.242080-11-paul.elder@ideasonboard.com
State Superseded
Delegated to: Paul Elder
Headers show
Series
  • IPA isolation implementation
Related show

Commit Message

Paul Elder Dec. 5, 2020, 10:30 a.m. UTC 
The raspberrypi IPA will depend on the raspberrypi IPA header generated
from the mojo definition file. Add the dependency. Simply add all
generated headers as a dependency, instead of walking the list of
headers, to simplify the implementation. This will have the effect of
generating all headers before compiling the IPA, which has no drawbacks.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

---
No change in v5

Changes in v4:
- rename libcamera_generated_headers to libcamera_generated_ipa_headers

Changes in v3:
- expand changelog

New in v2
---
 src/ipa/raspberrypi/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Niklas Söderlund Dec. 18, 2020, 4:33 p.m. UTC | #1 
Hi Paul,

Thanks for your work.

On 2020-12-05 19:30:53 +0900, Paul Elder wrote:
> The raspberrypi IPA will depend on the raspberrypi IPA header generated
> from the mojo definition file. Add the dependency. Simply add all
> generated headers as a dependency, instead of walking the list of
> headers, to simplify the implementation. This will have the effect of
> generating all headers before compiling the IPA, which has no drawbacks.
> 
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> 
> ---
> No change in v5
> 
> Changes in v4:
> - rename libcamera_generated_headers to libcamera_generated_ipa_headers
> 
> Changes in v3:
> - expand changelog
> 
> New in v2
> ---
>  src/ipa/raspberrypi/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build
> index 9445cd09..4331f718 100644
> --- a/src/ipa/raspberrypi/meson.build
> +++ b/src/ipa/raspberrypi/meson.build
> @@ -42,7 +42,7 @@ rpi_ipa_sources = files([
>  ])
>  
>  mod = shared_module(ipa_name,
> -                    rpi_ipa_sources,
> +                    [rpi_ipa_sources, libcamera_generated_ipa_headers],
>                      name_prefix : '',
>                      include_directories : rpi_ipa_includes,
>                      dependencies : rpi_ipa_deps,
> -- 
> 2.27.0
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch
diff mbox series 

diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build
index 9445cd09..4331f718 100644
--- a/src/ipa/raspberrypi/meson.build
+++ b/src/ipa/raspberrypi/meson.build
@@ -42,7 +42,7 @@  rpi_ipa_sources = files([
 ])
 
 mod = shared_module(ipa_name,
-                    rpi_ipa_sources,
+                    [rpi_ipa_sources, libcamera_generated_ipa_headers],
                     name_prefix : '',
                     include_directories : rpi_ipa_includes,
                     dependencies : rpi_ipa_deps,