[libcamera-devel,v3,4/4] src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor
diff mbox series

Message ID 20201126142321.5563-5-david.plowman@raspberrypi.com
State Accepted
Commit 5815bd0397bc63772642820a3c296b2c5fd7c791
Headers show
Series
  • Raspberry Pi AGC improvements
Related show

Commit Message

David Plowman Nov. 26, 2020, 2:23 p.m. UTC 
The exposure times in the exposure modes were causing AGC oscillations
because the algorithm was demanding long unachievable exposure times
but, without working sensor metadata, thought it was getting them when
actually it was not. We fix it by making the exposure profile request
only achievable exposure times, as we do for the ov5647 tuning.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/raspberrypi/data/imx219.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kieran Bingham Nov. 30, 2020, 11:07 a.m. UTC | #1 
Hi David,

On 26/11/2020 14:23, David Plowman wrote:
> The exposure times in the exposure modes were causing AGC oscillations
> because the algorithm was demanding long unachievable exposure times
> but, without working sensor metadata, thought it was getting them when
> actually it was not. We fix it by making the exposure profile request
> only achievable exposure times, as we do for the ov5647 tuning.
> 
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
> Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

And finally, pulling my tag forwards again.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>




> ---
>  src/ipa/raspberrypi/data/imx219.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json
> index b03a7beb..212f8b9a 100644
> --- a/src/ipa/raspberrypi/data/imx219.json
> +++ b/src/ipa/raspberrypi/data/imx219.json
> @@ -133,7 +133,7 @@
>              {
>                  "shutter":
>                  [
> -                    100, 10000, 30000, 60000, 120000
> +                    100, 10000, 30000, 30000, 30000
>                  ],
>                  "gain":
>                  [
> @@ -144,7 +144,7 @@
>              {
>                  "shutter":
>                  [
> -                    100, 5000, 10000, 20000, 120000
> +                    100, 5000, 10000, 20000, 30000
>                  ],
>                  "gain":
>                  [
>

Patch
diff mbox series 

diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json
index b03a7beb..212f8b9a 100644
--- a/src/ipa/raspberrypi/data/imx219.json
+++ b/src/ipa/raspberrypi/data/imx219.json
@@ -133,7 +133,7 @@ 
             {
                 "shutter":
                 [
-                    100, 10000, 30000, 60000, 120000
+                    100, 10000, 30000, 30000, 30000
                 ],
                 "gain":
                 [
@@ -144,7 +144,7 @@ 
             {
                 "shutter":
                 [
-                    100, 5000, 10000, 20000, 120000
+                    100, 5000, 10000, 20000, 30000
                 ],
                 "gain":
                 [