[libcamera-devel,1/2] src: ipa: raspberrypi: Add missing 'cloudly' AWB mode
diff mbox series

Message ID 20201117093205.9521-2-david.plowman@raspberrypi.com
State Accepted
Commit 589d4e6c20de24cc59cfcdb816ddc8a694fb268a
Headers show
Series
  • Raspberry Pi control fixes
Related show

Commit Message

David Plowman Nov. 17, 2020, 9:32 a.m. UTC 
This had just been forgotten.

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
---
 src/ipa/raspberrypi/raspberrypi.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Naushir Patuck Nov. 17, 2020, 11:13 a.m. UTC | #1 
Hi David,


On Tue, 17 Nov 2020 at 09:32, David Plowman <david.plowman@raspberrypi.com>
wrote:

> This had just been forgotten.
>
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
>

Reviewed-by: Naushir Patuck <naush@raspberrypi.com>


> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp
> b/src/ipa/raspberrypi/raspberrypi.cpp
> index 4632d764..9853a343 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -477,6 +477,7 @@ static const std::map<int32_t, std::string>
> AwbModeTable = {
>         { controls::AwbFluorescent, "fluorescent" },
>         { controls::AwbIndoor, "indoor" },
>         { controls::AwbDaylight, "daylight" },
> +       { controls::AwbCloudy, "cloudy" },
>         { controls::AwbCustom, "custom" },
>  };
>
> --
> 2.20.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
>
Kieran Bingham Nov. 18, 2020, 1:12 p.m. UTC | #2 
Hi David,

On 17/11/2020 09:32, David Plowman wrote:
> This had just been forgotten.

Perhaps:

"Support the 'cloudy' AWB mode which was left out when the AwbModeTable
was introduced."

But it doesn't warrant a resend, and doesn't really matter.


> 
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index 4632d764..9853a343 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -477,6 +477,7 @@ static const std::map<int32_t, std::string> AwbModeTable = {
>  	{ controls::AwbFluorescent, "fluorescent" },
>  	{ controls::AwbIndoor, "indoor" },
>  	{ controls::AwbDaylight, "daylight" },
> +	{ controls::AwbCloudy, "cloudy" },
>  	{ controls::AwbCustom, "custom" },

Is there any particular sort ordering on this table?

>  };
>  
>

Patch
diff mbox series 

diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
index 4632d764..9853a343 100644
--- a/src/ipa/raspberrypi/raspberrypi.cpp
+++ b/src/ipa/raspberrypi/raspberrypi.cpp
@@ -477,6 +477,7 @@  static const std::map<int32_t, std::string> AwbModeTable = {
 	{ controls::AwbFluorescent, "fluorescent" },
 	{ controls::AwbIndoor, "indoor" },
 	{ controls::AwbDaylight, "daylight" },
+	{ controls::AwbCloudy, "cloudy" },
 	{ controls::AwbCustom, "custom" },
 };