| Message ID | 20201106103707.49660-20-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, On Fri, Nov 06, 2020 at 07:36:49PM +0900, Paul Elder wrote: > With the new IPC infrastructure, we no longer need the C interface as > provided by struct ipa_context. Make ipaCreate return IPAinterface. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > --- > No change in v4 > > No change in v3 > > No change in v2 > --- > include/libcamera/ipa/ipa_interface.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h > index 8d4264c3..f6c40dc6 100644 > --- a/include/libcamera/ipa/ipa_interface.h > +++ b/include/libcamera/ipa/ipa_interface.h > @@ -50,4 +50,8 @@ public: > > } /* namespace libcamera */ > > +extern "C" { Is this to protect against C++ names manglingl and be able to load the symbol ? In the case I got it right: Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > +libcamera::IPAInterface *ipaCreate(); > +} > + > #endif /* __LIBCAMERA_IPA_INTERFACE_H__ */ > -- > 2.27.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Paul, Thank you for the patch. On Fri, Nov 06, 2020 at 07:36:49PM +0900, Paul Elder wrote: > With the new IPC infrastructure, we no longer need the C interface as > provided by struct ipa_context. Make ipaCreate return IPAinterface. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> I know it will all be squashed, but it would be easier to review the patches if the changes were not so fine-grained. Squashing this with the change that removes ipaCreate(), as well as the corresponding documentation changes, would be more self-contained. As you'll need to send a v5, *if* reworking this isn't too much work, it would be appreciated. > --- > No change in v4 > > No change in v3 > > No change in v2 > --- > include/libcamera/ipa/ipa_interface.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h > index 8d4264c3..f6c40dc6 100644 > --- a/include/libcamera/ipa/ipa_interface.h > +++ b/include/libcamera/ipa/ipa_interface.h > @@ -50,4 +50,8 @@ public: > > } /* namespace libcamera */ > > +extern "C" { > +libcamera::IPAInterface *ipaCreate(); > +} > + > #endif /* __LIBCAMERA_IPA_INTERFACE_H__ */
diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h index 8d4264c3..f6c40dc6 100644 --- a/include/libcamera/ipa/ipa_interface.h +++ b/include/libcamera/ipa/ipa_interface.h @@ -50,4 +50,8 @@ public: } /* namespace libcamera */ +extern "C" { +libcamera::IPAInterface *ipaCreate(); +} + #endif /* __LIBCAMERA_IPA_INTERFACE_H__ */
With the new IPC infrastructure, we no longer need the C interface as provided by struct ipa_context. Make ipaCreate return IPAinterface. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- No change in v4 No change in v3 No change in v2 --- include/libcamera/ipa/ipa_interface.h | 4 ++++ 1 file changed, 4 insertions(+)