| Message ID | 20201030014134.15851-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 7f1ebbab3864b83c1a1bd12f1ca7f2689fbb07d0 |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On 10/30/20 7:11 AM, Laurent Pinchart wrote: > The JPEG post-processor is marked as licensed under GPL-2.0-or-later. > This is an oversight and unvoluntary. License it under the > LGPL-2.1-or-later as the rest of the camera HAL implementation. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Oops! Acked-by: Umang Jain <email@uajain.com> > --- > src/android/jpeg/post_processor_jpeg.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Umang, Hiro-san, as you've both authored commits that touch this file, > could you please explicitly reply with an Acked-by ? > > This is the second time this happens, I think we need a check in either > checkstyle.py or in the git pre-push hook. I think checking the license would indeed would be a good candidate for checkstyle.py. > > diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp > index b9b9dc0042c9..436a50f85664 100644 > --- a/src/android/jpeg/post_processor_jpeg.cpp > +++ b/src/android/jpeg/post_processor_jpeg.cpp > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* SPDX-License-Identifier: LGPL-2.1-or-later */ > /* > * Copyright (C) 2020, Google Inc. > *
Hi Hiro, Could you please ack this patch ? On Fri, Oct 30, 2020 at 03:41:34AM +0200, Laurent Pinchart wrote: > The JPEG post-processor is marked as licensed under GPL-2.0-or-later. > This is an oversight and unvoluntary. License it under the > LGPL-2.1-or-later as the rest of the camera HAL implementation. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/android/jpeg/post_processor_jpeg.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Umang, Hiro-san, as you've both authored commits that touch this file, > could you please explicitly reply with an Acked-by ? > > This is the second time this happens, I think we need a check in either > checkstyle.py or in the git pre-push hook. > > diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp > index b9b9dc0042c9..436a50f85664 100644 > --- a/src/android/jpeg/post_processor_jpeg.cpp > +++ b/src/android/jpeg/post_processor_jpeg.cpp > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0-or-later */ > +/* SPDX-License-Identifier: LGPL-2.1-or-later */ > /* > * Copyright (C) 2020, Google Inc. > *
Hi Hiro, On Wed, Nov 04, 2020 at 09:50:31AM +0200, Laurent Pinchart wrote: > Hi Hiro, > > Could you please ack this patch ? Ping ? > On Fri, Oct 30, 2020 at 03:41:34AM +0200, Laurent Pinchart wrote: > > The JPEG post-processor is marked as licensed under GPL-2.0-or-later. > > This is an oversight and unvoluntary. License it under the > > LGPL-2.1-or-later as the rest of the camera HAL implementation. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > src/android/jpeg/post_processor_jpeg.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Umang, Hiro-san, as you've both authored commits that touch this file, > > could you please explicitly reply with an Acked-by ? > > > > This is the second time this happens, I think we need a check in either > > checkstyle.py or in the git pre-push hook. > > > > diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp > > index b9b9dc0042c9..436a50f85664 100644 > > --- a/src/android/jpeg/post_processor_jpeg.cpp > > +++ b/src/android/jpeg/post_processor_jpeg.cpp > > @@ -1,4 +1,4 @@ > > -/* SPDX-License-Identifier: GPL-2.0-or-later */ > > +/* SPDX-License-Identifier: LGPL-2.1-or-later */ > > /* > > * Copyright (C) 2020, Google Inc. > > *
Oops, I missed this mail. Sorry for the delay. On Mon, Nov 16, 2020 at 4:59 AM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Hiro, > > On Wed, Nov 04, 2020 at 09:50:31AM +0200, Laurent Pinchart wrote: > > Hi Hiro, > > > > Could you please ack this patch ? > > Ping ? > > > On Fri, Oct 30, 2020 at 03:41:34AM +0200, Laurent Pinchart wrote: > > > The JPEG post-processor is marked as licensed under GPL-2.0-or-later. > > > This is an oversight and unvoluntary. License it under the > > > LGPL-2.1-or-later as the rest of the camera HAL implementation. > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Hirokazu Honda <hiroh@chromium.org> > > > --- > > > src/android/jpeg/post_processor_jpeg.cpp | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Umang, Hiro-san, as you've both authored commits that touch this file, > > > could you please explicitly reply with an Acked-by ? > > > > > > This is the second time this happens, I think we need a check in either > > > checkstyle.py or in the git pre-push hook. > > > > > > diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp > > > index b9b9dc0042c9..436a50f85664 100644 > > > --- a/src/android/jpeg/post_processor_jpeg.cpp > > > +++ b/src/android/jpeg/post_processor_jpeg.cpp > > > @@ -1,4 +1,4 @@ > > > -/* SPDX-License-Identifier: GPL-2.0-or-later */ > > > +/* SPDX-License-Identifier: LGPL-2.1-or-later */ > > > /* > > > * Copyright (C) 2020, Google Inc. > > > * > > -- > Regards, > > Laurent Pinchart
diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp index b9b9dc0042c9..436a50f85664 100644 --- a/src/android/jpeg/post_processor_jpeg.cpp +++ b/src/android/jpeg/post_processor_jpeg.cpp @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ /* * Copyright (C) 2020, Google Inc. *
The JPEG post-processor is marked as licensed under GPL-2.0-or-later. This is an oversight and unvoluntary. License it under the LGPL-2.1-or-later as the rest of the camera HAL implementation. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/android/jpeg/post_processor_jpeg.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Umang, Hiro-san, as you've both authored commits that touch this file, could you please explicitly reply with an Acked-by ? This is the second time this happens, I think we need a check in either checkstyle.py or in the git pre-push hook.