| Message ID | 20201029073305.12803-1-sebastian.fricke.linux@gmail.com |
|---|---|
| State | Accepted |
| Commit | 58d487b10e06ad823103957c1e6aa2201720fdae |
| Headers | show |
| Series |
|
| Related | show |
Hi Sebastian, On Thu, Oct 29, 2020 at 08:33:05AM +0100, Sebastian Fricke wrote: > The class IPAManager has no method ipaCreate, but the method createIPA. > > s/pipeline handlers call the IPAManager::ipaCreate() > /pipeline handlers call the IPAManager::createIPA() > > Signed-off-by: Sebastian Fricke <sebastian.fricke.linux@gmail.com> Thanks Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> > --- > src/libcamera/ipa_manager.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp > index 046fd5c..ad05b9c 100644 > --- a/src/libcamera/ipa_manager.cpp > +++ b/src/libcamera/ipa_manager.cpp > @@ -43,7 +43,7 @@ LOG_DEFINE_CATEGORY(IPAManager) > * The isolation mechanism ensures that no code from a closed-source module is > * ever run in the libcamera process. > * > - * To create an IPA context, pipeline handlers call the IPAManager::ipaCreate() > + * To create an IPA context, pipeline handlers call the IPAManager::createIPA() > * method. For a directly loaded module, the manager calls the module's > * ipaCreate() function directly and wraps the returned context in an > * IPAContextWrapper that exposes an IPAInterface. > -- > 2.20.1 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Sebastian, Thank you for the patch. On Thu, Oct 29, 2020 at 08:33:05AM +0100, Sebastian Fricke wrote: > The class IPAManager has no method ipaCreate, but the method createIPA. > > s/pipeline handlers call the IPAManager::ipaCreate() > /pipeline handlers call the IPAManager::createIPA() > > Signed-off-by: Sebastian Fricke <sebastian.fricke.linux@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I'll push this in a moment. > --- > src/libcamera/ipa_manager.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp > index 046fd5c..ad05b9c 100644 > --- a/src/libcamera/ipa_manager.cpp > +++ b/src/libcamera/ipa_manager.cpp > @@ -43,7 +43,7 @@ LOG_DEFINE_CATEGORY(IPAManager) > * The isolation mechanism ensures that no code from a closed-source module is > * ever run in the libcamera process. > * > - * To create an IPA context, pipeline handlers call the IPAManager::ipaCreate() > + * To create an IPA context, pipeline handlers call the IPAManager::createIPA() > * method. For a directly loaded module, the manager calls the module's > * ipaCreate() function directly and wraps the returned context in an > * IPAContextWrapper that exposes an IPAInterface.
diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp index 046fd5c..ad05b9c 100644 --- a/src/libcamera/ipa_manager.cpp +++ b/src/libcamera/ipa_manager.cpp @@ -43,7 +43,7 @@ LOG_DEFINE_CATEGORY(IPAManager) * The isolation mechanism ensures that no code from a closed-source module is * ever run in the libcamera process. * - * To create an IPA context, pipeline handlers call the IPAManager::ipaCreate() + * To create an IPA context, pipeline handlers call the IPAManager::createIPA() * method. For a directly loaded module, the manager calls the module's * ipaCreate() function directly and wraps the returned context in an * IPAContextWrapper that exposes an IPAInterface.
The class IPAManager has no method ipaCreate, but the method createIPA. s/pipeline handlers call the IPAManager::ipaCreate() /pipeline handlers call the IPAManager::createIPA() Signed-off-by: Sebastian Fricke <sebastian.fricke.linux@gmail.com> --- src/libcamera/ipa_manager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)