[libcamera-devel,v2,8/8] meson: Enable -Wextra-semi for clang
diff mbox series

Message ID 20201020091505.138898-8-hiroh@chromium.org
State Accepted
Commit c3a5467f7d91807ed8c6dbdee107638ceca15b1c
Headers show
Series
  • [libcamera-devel,v2,1/8] test: Omit extra semicolons
Related show

Commit Message

Hirokazu Honda Oct. 20, 2020, 9:15 a.m. UTC 
The option, -Wextra-semi, helps developers to find unnecessary
semicolons. This option is available with clang.

Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 meson.build | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Kieran Bingham Oct. 20, 2020, 10:07 a.m. UTC | #1 
Hi Hiro,

On 20/10/2020 10:15, Hirokazu Honda wrote:
> The option, -Wextra-semi, helps developers to find unnecessary
> semicolons. This option is available with clang.
> 
> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

So I only actually had comments on 6/8.

For this and all other patches in this series:
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  meson.build | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index de15cc1..b0c17d3 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -64,6 +64,10 @@ if cc.get_id() == 'clang'
>              '-stdlib=libc++',
>          ]
>      endif
> +
> +    cpp_arguments += [
> +        '-Wextra-semi',
> +    ]
>  endif
>  
>  if cc.get_id() == 'gcc'
>
Hirokazu Honda Oct. 21, 2020, 12:38 a.m. UTC | #2 
Thanks Kieran and Niklas for reviewing.
Thanks Laurent for pushing the series to master.


On Tue, Oct 20, 2020 at 7:07 PM Kieran Bingham
<kieran.bingham@ideasonboard.com> wrote:
>
> Hi Hiro,
>
> On 20/10/2020 10:15, Hirokazu Honda wrote:
> > The option, -Wextra-semi, helps developers to find unnecessary
> > semicolons. This option is available with clang.
> >
> > Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> So I only actually had comments on 6/8.
>
> For this and all other patches in this series:
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> > ---
> >  meson.build | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meson.build b/meson.build
> > index de15cc1..b0c17d3 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -64,6 +64,10 @@ if cc.get_id() == 'clang'
> >              '-stdlib=libc++',
> >          ]
> >      endif
> > +
> > +    cpp_arguments += [
> > +        '-Wextra-semi',
> > +    ]
> >  endif
> >
> >  if cc.get_id() == 'gcc'
> >
>
> --
> Regards
> --
> Kieran

Patch
diff mbox series 

diff --git a/meson.build b/meson.build
index de15cc1..b0c17d3 100644
--- a/meson.build
+++ b/meson.build
@@ -64,6 +64,10 @@  if cc.get_id() == 'clang'
             '-stdlib=libc++',
         ]
     endif
+
+    cpp_arguments += [
+        '-Wextra-semi',
+    ]
 endif
 
 if cc.get_id() == 'gcc'