| Message ID | 20201020052905.89267-2-hiroh@chromium.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Hiro-san, Thank you for the patch. On Tue, Oct 20, 2020 at 02:28:58PM +0900, Hirokazu Honda wrote: > TEST_REGISTER macro is main function. The end semicolon with the > macro is unnecessary. > > Signed-off-by: Hirokazu Honda <hiroh@chromium.org> > --- > test/camera/buffer_import.cpp | 2 +- > test/camera/capture.cpp | 2 +- > test/camera/configuration_default.cpp | 2 +- > test/camera/configuration_set.cpp | 2 +- > test/camera/statemachine.cpp | 2 +- > test/mapped-buffer.cpp | 2 +- > test/media_device/media_device_acquire.cpp | 2 +- > test/media_device/media_device_link_test.cpp | 2 +- > test/media_device/media_device_print_test.cpp | 2 +- > test/v4l2_subdevice/list_formats.cpp | 2 +- > test/v4l2_subdevice/test_formats.cpp | 2 +- > test/v4l2_videodevice/buffer_cache.cpp | 2 +- > test/v4l2_videodevice/buffer_sharing.cpp | 2 +- > test/v4l2_videodevice/capture_async.cpp | 2 +- > test/v4l2_videodevice/controls.cpp | 2 +- > test/v4l2_videodevice/double_open.cpp | 2 +- > test/v4l2_videodevice/formats.cpp | 2 +- > test/v4l2_videodevice/request_buffers.cpp | 2 +- > test/v4l2_videodevice/stream_on_off.cpp | 2 +- > test/v4l2_videodevice/v4l2_m2mdevice.cpp | 4 ++-- > 20 files changed, 21 insertions(+), 21 deletions(-) > > diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp > index 72ce7b7..4b626df 100644 > --- a/test/camera/buffer_import.cpp > +++ b/test/camera/buffer_import.cpp > @@ -168,4 +168,4 @@ private: > > } /* namespace */ > > -TEST_REGISTER(BufferImportTest); > +TEST_REGISTER(BufferImportTest) > diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp > index c077080..f13ca53 100644 > --- a/test/camera/capture.cpp > +++ b/test/camera/capture.cpp > @@ -168,4 +168,4 @@ protected: > > } /* namespace */ > > -TEST_REGISTER(Capture); > +TEST_REGISTER(Capture) > diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp > index cdd6cb9..c2b2019 100644 > --- a/test/camera/configuration_default.cpp > +++ b/test/camera/configuration_default.cpp > @@ -56,4 +56,4 @@ protected: > > } /* namespace */ > > -TEST_REGISTER(ConfigurationDefault); > +TEST_REGISTER(ConfigurationDefault) > diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp > index 30f19ba..a1dc446 100644 > --- a/test/camera/configuration_set.cpp > +++ b/test/camera/configuration_set.cpp > @@ -102,4 +102,4 @@ protected: > > } /* namespace */ > > -TEST_REGISTER(ConfigurationSet); > +TEST_REGISTER(ConfigurationSet) > diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp > index e63ab29..f0c3d77 100644 > --- a/test/camera/statemachine.cpp > +++ b/test/camera/statemachine.cpp > @@ -211,4 +211,4 @@ protected: > > } /* namespace */ > > -TEST_REGISTER(Statemachine); > +TEST_REGISTER(Statemachine) > diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp > index 0279233..5de8201 100644 > --- a/test/mapped-buffer.cpp > +++ b/test/mapped-buffer.cpp > @@ -113,4 +113,4 @@ private: > > } /* namespace */ > > -TEST_REGISTER(MappedBufferTest); > +TEST_REGISTER(MappedBufferTest) > diff --git a/test/media_device/media_device_acquire.cpp b/test/media_device/media_device_acquire.cpp > index d1e3d74..371e30e 100644 > --- a/test/media_device/media_device_acquire.cpp > +++ b/test/media_device/media_device_acquire.cpp > @@ -30,4 +30,4 @@ class MediaDeviceAcquire : public MediaDeviceTest > } > }; > > -TEST_REGISTER(MediaDeviceAcquire); > +TEST_REGISTER(MediaDeviceAcquire) > diff --git a/test/media_device/media_device_link_test.cpp b/test/media_device/media_device_link_test.cpp > index fe7542b..5c74905 100644 > --- a/test/media_device/media_device_link_test.cpp > +++ b/test/media_device/media_device_link_test.cpp > @@ -219,4 +219,4 @@ class MediaDeviceLinkTest : public MediaDeviceTest > } > }; > > -TEST_REGISTER(MediaDeviceLinkTest); > +TEST_REGISTER(MediaDeviceLinkTest) > diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp > index 1f5e3f3..436d4e8 100644 > --- a/test/media_device/media_device_print_test.cpp > +++ b/test/media_device/media_device_print_test.cpp > @@ -151,4 +151,4 @@ int MediaDevicePrintTest::run() > return ret; > } > > -TEST_REGISTER(MediaDevicePrintTest); > +TEST_REGISTER(MediaDevicePrintTest) > diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp > index a6044c0..74ec81a 100644 > --- a/test/v4l2_subdevice/list_formats.cpp > +++ b/test/v4l2_subdevice/list_formats.cpp > @@ -79,4 +79,4 @@ int ListFormatsTest::run() > return TestPass; > } > > -TEST_REGISTER(ListFormatsTest); > +TEST_REGISTER(ListFormatsTest) > diff --git a/test/v4l2_subdevice/test_formats.cpp b/test/v4l2_subdevice/test_formats.cpp > index 679f50b..47f979e 100644 > --- a/test/v4l2_subdevice/test_formats.cpp > +++ b/test/v4l2_subdevice/test_formats.cpp > @@ -75,4 +75,4 @@ int FormatHandlingTest::run() > return TestPass; > } > > -TEST_REGISTER(FormatHandlingTest); > +TEST_REGISTER(FormatHandlingTest) > diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp > index b22de88..b3f2bec 100644 > --- a/test/v4l2_videodevice/buffer_cache.cpp > +++ b/test/v4l2_videodevice/buffer_cache.cpp > @@ -213,4 +213,4 @@ private: > > } /* namespace */ > > -TEST_REGISTER(BufferCacheTest); > +TEST_REGISTER(BufferCacheTest) > diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp > index ba2cc40..5e7e2d9 100644 > --- a/test/v4l2_videodevice/buffer_sharing.cpp > +++ b/test/v4l2_videodevice/buffer_sharing.cpp > @@ -200,4 +200,4 @@ private: > unsigned int framesOutput_; > }; > > -TEST_REGISTER(BufferSharingTest); > +TEST_REGISTER(BufferSharingTest) > diff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp > index 13cbcc8..2b38102 100644 > --- a/test/v4l2_videodevice/capture_async.cpp > +++ b/test/v4l2_videodevice/capture_async.cpp > @@ -88,4 +88,4 @@ private: > unsigned int frames; > }; > > -TEST_REGISTER(CaptureAsyncTest); > +TEST_REGISTER(CaptureAsyncTest) > diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp > index 9f09d03..8d42508 100644 > --- a/test/v4l2_videodevice/controls.cpp > +++ b/test/v4l2_videodevice/controls.cpp > @@ -127,4 +127,4 @@ protected: > } > }; > > -TEST_REGISTER(V4L2ControlTest); > +TEST_REGISTER(V4L2ControlTest) > diff --git a/test/v4l2_videodevice/double_open.cpp b/test/v4l2_videodevice/double_open.cpp > index 5768d40..7d11f6f 100644 > --- a/test/v4l2_videodevice/double_open.cpp > +++ b/test/v4l2_videodevice/double_open.cpp > @@ -38,4 +38,4 @@ protected: > > } /* namespace */ > > -TEST_REGISTER(DoubleOpen); > +TEST_REGISTER(DoubleOpen) > diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp > index 043732d..b5020d2 100644 > --- a/test/v4l2_videodevice/formats.cpp > +++ b/test/v4l2_videodevice/formats.cpp > @@ -74,4 +74,4 @@ protected: > } > }; > > -TEST_REGISTER(Format); > +TEST_REGISTER(Format) > diff --git a/test/v4l2_videodevice/request_buffers.cpp b/test/v4l2_videodevice/request_buffers.cpp > index 2f8dfe1..fb57714 100644 > --- a/test/v4l2_videodevice/request_buffers.cpp > +++ b/test/v4l2_videodevice/request_buffers.cpp > @@ -26,4 +26,4 @@ protected: > } > }; > > -TEST_REGISTER(RequestBuffersTest); > +TEST_REGISTER(RequestBuffersTest) > diff --git a/test/v4l2_videodevice/stream_on_off.cpp b/test/v4l2_videodevice/stream_on_off.cpp > index ce48310..4ed99e9 100644 > --- a/test/v4l2_videodevice/stream_on_off.cpp > +++ b/test/v4l2_videodevice/stream_on_off.cpp > @@ -33,4 +33,4 @@ protected: > } > }; > > -TEST_REGISTER(StreamOnStreamOffTest); > +TEST_REGISTER(StreamOnStreamOffTest) > diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp > index 44a39d4..616261e 100644 > --- a/test/v4l2_videodevice/v4l2_m2mdevice.cpp > +++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp > @@ -187,7 +187,7 @@ protected: > void cleanup() > { > delete vim2m_; > - }; > + } This isn't described in the commit message, but I think it's fine in this case. It's covered by the subject of the patch. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > private: > std::unique_ptr<DeviceEnumerator> enumerator_; > @@ -201,4 +201,4 @@ private: > unsigned int captureFrames_; > }; > > -TEST_REGISTER(V4L2M2MDeviceTest); > +TEST_REGISTER(V4L2M2MDeviceTest)
diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp index 72ce7b7..4b626df 100644 --- a/test/camera/buffer_import.cpp +++ b/test/camera/buffer_import.cpp @@ -168,4 +168,4 @@ private: } /* namespace */ -TEST_REGISTER(BufferImportTest); +TEST_REGISTER(BufferImportTest) diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp index c077080..f13ca53 100644 --- a/test/camera/capture.cpp +++ b/test/camera/capture.cpp @@ -168,4 +168,4 @@ protected: } /* namespace */ -TEST_REGISTER(Capture); +TEST_REGISTER(Capture) diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp index cdd6cb9..c2b2019 100644 --- a/test/camera/configuration_default.cpp +++ b/test/camera/configuration_default.cpp @@ -56,4 +56,4 @@ protected: } /* namespace */ -TEST_REGISTER(ConfigurationDefault); +TEST_REGISTER(ConfigurationDefault) diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp index 30f19ba..a1dc446 100644 --- a/test/camera/configuration_set.cpp +++ b/test/camera/configuration_set.cpp @@ -102,4 +102,4 @@ protected: } /* namespace */ -TEST_REGISTER(ConfigurationSet); +TEST_REGISTER(ConfigurationSet) diff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp index e63ab29..f0c3d77 100644 --- a/test/camera/statemachine.cpp +++ b/test/camera/statemachine.cpp @@ -211,4 +211,4 @@ protected: } /* namespace */ -TEST_REGISTER(Statemachine); +TEST_REGISTER(Statemachine) diff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp index 0279233..5de8201 100644 --- a/test/mapped-buffer.cpp +++ b/test/mapped-buffer.cpp @@ -113,4 +113,4 @@ private: } /* namespace */ -TEST_REGISTER(MappedBufferTest); +TEST_REGISTER(MappedBufferTest) diff --git a/test/media_device/media_device_acquire.cpp b/test/media_device/media_device_acquire.cpp index d1e3d74..371e30e 100644 --- a/test/media_device/media_device_acquire.cpp +++ b/test/media_device/media_device_acquire.cpp @@ -30,4 +30,4 @@ class MediaDeviceAcquire : public MediaDeviceTest } }; -TEST_REGISTER(MediaDeviceAcquire); +TEST_REGISTER(MediaDeviceAcquire) diff --git a/test/media_device/media_device_link_test.cpp b/test/media_device/media_device_link_test.cpp index fe7542b..5c74905 100644 --- a/test/media_device/media_device_link_test.cpp +++ b/test/media_device/media_device_link_test.cpp @@ -219,4 +219,4 @@ class MediaDeviceLinkTest : public MediaDeviceTest } }; -TEST_REGISTER(MediaDeviceLinkTest); +TEST_REGISTER(MediaDeviceLinkTest) diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp index 1f5e3f3..436d4e8 100644 --- a/test/media_device/media_device_print_test.cpp +++ b/test/media_device/media_device_print_test.cpp @@ -151,4 +151,4 @@ int MediaDevicePrintTest::run() return ret; } -TEST_REGISTER(MediaDevicePrintTest); +TEST_REGISTER(MediaDevicePrintTest) diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp index a6044c0..74ec81a 100644 --- a/test/v4l2_subdevice/list_formats.cpp +++ b/test/v4l2_subdevice/list_formats.cpp @@ -79,4 +79,4 @@ int ListFormatsTest::run() return TestPass; } -TEST_REGISTER(ListFormatsTest); +TEST_REGISTER(ListFormatsTest) diff --git a/test/v4l2_subdevice/test_formats.cpp b/test/v4l2_subdevice/test_formats.cpp index 679f50b..47f979e 100644 --- a/test/v4l2_subdevice/test_formats.cpp +++ b/test/v4l2_subdevice/test_formats.cpp @@ -75,4 +75,4 @@ int FormatHandlingTest::run() return TestPass; } -TEST_REGISTER(FormatHandlingTest); +TEST_REGISTER(FormatHandlingTest) diff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp index b22de88..b3f2bec 100644 --- a/test/v4l2_videodevice/buffer_cache.cpp +++ b/test/v4l2_videodevice/buffer_cache.cpp @@ -213,4 +213,4 @@ private: } /* namespace */ -TEST_REGISTER(BufferCacheTest); +TEST_REGISTER(BufferCacheTest) diff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp index ba2cc40..5e7e2d9 100644 --- a/test/v4l2_videodevice/buffer_sharing.cpp +++ b/test/v4l2_videodevice/buffer_sharing.cpp @@ -200,4 +200,4 @@ private: unsigned int framesOutput_; }; -TEST_REGISTER(BufferSharingTest); +TEST_REGISTER(BufferSharingTest) diff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp index 13cbcc8..2b38102 100644 --- a/test/v4l2_videodevice/capture_async.cpp +++ b/test/v4l2_videodevice/capture_async.cpp @@ -88,4 +88,4 @@ private: unsigned int frames; }; -TEST_REGISTER(CaptureAsyncTest); +TEST_REGISTER(CaptureAsyncTest) diff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp index 9f09d03..8d42508 100644 --- a/test/v4l2_videodevice/controls.cpp +++ b/test/v4l2_videodevice/controls.cpp @@ -127,4 +127,4 @@ protected: } }; -TEST_REGISTER(V4L2ControlTest); +TEST_REGISTER(V4L2ControlTest) diff --git a/test/v4l2_videodevice/double_open.cpp b/test/v4l2_videodevice/double_open.cpp index 5768d40..7d11f6f 100644 --- a/test/v4l2_videodevice/double_open.cpp +++ b/test/v4l2_videodevice/double_open.cpp @@ -38,4 +38,4 @@ protected: } /* namespace */ -TEST_REGISTER(DoubleOpen); +TEST_REGISTER(DoubleOpen) diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp index 043732d..b5020d2 100644 --- a/test/v4l2_videodevice/formats.cpp +++ b/test/v4l2_videodevice/formats.cpp @@ -74,4 +74,4 @@ protected: } }; -TEST_REGISTER(Format); +TEST_REGISTER(Format) diff --git a/test/v4l2_videodevice/request_buffers.cpp b/test/v4l2_videodevice/request_buffers.cpp index 2f8dfe1..fb57714 100644 --- a/test/v4l2_videodevice/request_buffers.cpp +++ b/test/v4l2_videodevice/request_buffers.cpp @@ -26,4 +26,4 @@ protected: } }; -TEST_REGISTER(RequestBuffersTest); +TEST_REGISTER(RequestBuffersTest) diff --git a/test/v4l2_videodevice/stream_on_off.cpp b/test/v4l2_videodevice/stream_on_off.cpp index ce48310..4ed99e9 100644 --- a/test/v4l2_videodevice/stream_on_off.cpp +++ b/test/v4l2_videodevice/stream_on_off.cpp @@ -33,4 +33,4 @@ protected: } }; -TEST_REGISTER(StreamOnStreamOffTest); +TEST_REGISTER(StreamOnStreamOffTest) diff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp index 44a39d4..616261e 100644 --- a/test/v4l2_videodevice/v4l2_m2mdevice.cpp +++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp @@ -187,7 +187,7 @@ protected: void cleanup() { delete vim2m_; - }; + } private: std::unique_ptr<DeviceEnumerator> enumerator_; @@ -201,4 +201,4 @@ private: unsigned int captureFrames_; }; -TEST_REGISTER(V4L2M2MDeviceTest); +TEST_REGISTER(V4L2M2MDeviceTest)
TEST_REGISTER macro is main function. The end semicolon with the macro is unnecessary. Signed-off-by: Hirokazu Honda <hiroh@chromium.org> --- test/camera/buffer_import.cpp | 2 +- test/camera/capture.cpp | 2 +- test/camera/configuration_default.cpp | 2 +- test/camera/configuration_set.cpp | 2 +- test/camera/statemachine.cpp | 2 +- test/mapped-buffer.cpp | 2 +- test/media_device/media_device_acquire.cpp | 2 +- test/media_device/media_device_link_test.cpp | 2 +- test/media_device/media_device_print_test.cpp | 2 +- test/v4l2_subdevice/list_formats.cpp | 2 +- test/v4l2_subdevice/test_formats.cpp | 2 +- test/v4l2_videodevice/buffer_cache.cpp | 2 +- test/v4l2_videodevice/buffer_sharing.cpp | 2 +- test/v4l2_videodevice/capture_async.cpp | 2 +- test/v4l2_videodevice/controls.cpp | 2 +- test/v4l2_videodevice/double_open.cpp | 2 +- test/v4l2_videodevice/formats.cpp | 2 +- test/v4l2_videodevice/request_buffers.cpp | 2 +- test/v4l2_videodevice/stream_on_off.cpp | 2 +- test/v4l2_videodevice/v4l2_m2mdevice.cpp | 4 ++-- 20 files changed, 21 insertions(+), 21 deletions(-)