[libcamera-devel,3/3] android: CameraStream: Fix nitpick indentation for mutex_
diff mbox series

Message ID 20201015171457.75678-4-email@uajain.com
State Accepted
Headers show
Series
  • android: Introduce PostProcessor interface
Related show

Commit Message

Umang Jain Oct. 15, 2020, 5:14 p.m. UTC 
Signed-off-by: Umang Jain <email@uajain.com>
---
 src/android/camera_stream.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Oct. 15, 2020, 7:33 p.m. UTC | #1 
Hi Umang,

On 15/10/2020 18:14, Umang Jain wrote:
> Signed-off-by: Umang Jain <email@uajain.com>

I'd be tempted to put this at the start of the series, so you clean up
then build on top.

But it's not essential,

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/android/camera_stream.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h
> index c55d90b..c2cb121 100644
> --- a/src/android/camera_stream.h
> +++ b/src/android/camera_stream.h
> @@ -141,7 +141,7 @@ private:
>  	 * The class has to be MoveConstructible as instances are stored in
>  	 * an std::vector in CameraDevice.
>  	 */
> -	 std::unique_ptr<std::mutex> mutex_;
> +	std::unique_ptr<std::mutex> mutex_;
>  	std::unique_ptr<PostProcessor> postProcessor_;
>  };
>  
>
Laurent Pinchart Oct. 16, 2020, 4:24 a.m. UTC | #2 
Hi Umang,

Thank you for the patch.

On Thu, Oct 15, 2020 at 10:44:57PM +0530, Umang Jain wrote:
> Signed-off-by: Umang Jain <email@uajain.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/android/camera_stream.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h
> index c55d90b..c2cb121 100644
> --- a/src/android/camera_stream.h
> +++ b/src/android/camera_stream.h
> @@ -141,7 +141,7 @@ private:
>  	 * The class has to be MoveConstructible as instances are stored in
>  	 * an std::vector in CameraDevice.
>  	 */
> -	 std::unique_ptr<std::mutex> mutex_;
> +	std::unique_ptr<std::mutex> mutex_;
>  	std::unique_ptr<PostProcessor> postProcessor_;
>  };
>

Patch
diff mbox series 

diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h
index c55d90b..c2cb121 100644
--- a/src/android/camera_stream.h
+++ b/src/android/camera_stream.h
@@ -141,7 +141,7 @@  private:
 	 * The class has to be MoveConstructible as instances are stored in
 	 * an std::vector in CameraDevice.
 	 */
-	 std::unique_ptr<std::mutex> mutex_;
+	std::unique_ptr<std::mutex> mutex_;
 	std::unique_ptr<PostProcessor> postProcessor_;
 };