[libcamera-devel] android: jpeg: Use LGPL-2.1 license
diff mbox series

Message ID 20201009080026.31566-1-email@uajain.com
State Accepted
Commit 48d304392b25d5ffe38504e7b5ee9d5f1f6dd9af
Headers show
Series
  • [libcamera-devel] android: jpeg: Use LGPL-2.1 license
Related show

Commit Message

Umang Jain Oct. 9, 2020, 8 a.m. UTC
The jpeg components should use LGPL-2.1-or-later license instead of
the GPL-2.0.

Signed-off-by: Umang Jain <email@uajain.com>
---
 src/android/jpeg/encoder.h           | 2 +-
 src/android/jpeg/encoder_libjpeg.cpp | 2 +-
 src/android/jpeg/encoder_libjpeg.h   | 2 +-
 src/android/jpeg/exif.cpp            | 2 +-
 src/android/jpeg/exif.h              | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

Comments

Kieran Bingham Oct. 9, 2020, 11:51 a.m. UTC | #1
Hi Umang,

On 09/10/2020 09:00, Umang Jain wrote:
> The jpeg components should use LGPL-2.1-or-later license instead of
> the GPL-2.0.

Indeed, good spot.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> Signed-off-by: Umang Jain <email@uajain.com>
> ---
>  src/android/jpeg/encoder.h           | 2 +-
>  src/android/jpeg/encoder_libjpeg.cpp | 2 +-
>  src/android/jpeg/encoder_libjpeg.h   | 2 +-
>  src/android/jpeg/exif.cpp            | 2 +-
>  src/android/jpeg/exif.h              | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h
> index cf26d67..4483153 100644
> --- a/src/android/jpeg/encoder.h
> +++ b/src/android/jpeg/encoder.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2020, Google Inc.
>   *
> diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp
> index 510613c..a77f5b2 100644
> --- a/src/android/jpeg/encoder_libjpeg.cpp
> +++ b/src/android/jpeg/encoder_libjpeg.cpp
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2020, Google Inc.
>   *
> diff --git a/src/android/jpeg/encoder_libjpeg.h b/src/android/jpeg/encoder_libjpeg.h
> index 1e8df05..934caef 100644
> --- a/src/android/jpeg/encoder_libjpeg.h
> +++ b/src/android/jpeg/encoder_libjpeg.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2020, Google Inc.
>   *
> diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp
> index e4a116d..d21534a 100644
> --- a/src/android/jpeg/exif.cpp
> +++ b/src/android/jpeg/exif.cpp
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2020, Google Inc.
>   *
> diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h
> index 77d1177..12c27b6 100644
> --- a/src/android/jpeg/exif.h
> +++ b/src/android/jpeg/exif.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2020, Google Inc.
>   *
>
Laurent Pinchart Oct. 9, 2020, 10:37 p.m. UTC | #2
Hi Umang,

Thank you for the patch.

On Fri, Oct 09, 2020 at 01:30:26PM +0530, Umang Jain wrote:
> The jpeg components should use LGPL-2.1-or-later license instead of
> the GPL-2.0.

It was indeed an oversight.

I'll push the patch with the following update to the commit message to
clarify that the GPL-2.0 has never been our intent.

"The jpeg components are licensed under GPL-2.0-or-later. This is an
oversight and unvoluntary. License them under the LGPL-2.1-or-later as
the rest of the camera HAL implementation."

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Umang Jain <email@uajain.com>
> ---
>  src/android/jpeg/encoder.h           | 2 +-
>  src/android/jpeg/encoder_libjpeg.cpp | 2 +-
>  src/android/jpeg/encoder_libjpeg.h   | 2 +-
>  src/android/jpeg/exif.cpp            | 2 +-
>  src/android/jpeg/exif.h              | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h
> index cf26d67..4483153 100644
> --- a/src/android/jpeg/encoder.h
> +++ b/src/android/jpeg/encoder.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2020, Google Inc.
>   *
> diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp
> index 510613c..a77f5b2 100644
> --- a/src/android/jpeg/encoder_libjpeg.cpp
> +++ b/src/android/jpeg/encoder_libjpeg.cpp
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2020, Google Inc.
>   *
> diff --git a/src/android/jpeg/encoder_libjpeg.h b/src/android/jpeg/encoder_libjpeg.h
> index 1e8df05..934caef 100644
> --- a/src/android/jpeg/encoder_libjpeg.h
> +++ b/src/android/jpeg/encoder_libjpeg.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2020, Google Inc.
>   *
> diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp
> index e4a116d..d21534a 100644
> --- a/src/android/jpeg/exif.cpp
> +++ b/src/android/jpeg/exif.cpp
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2020, Google Inc.
>   *
> diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h
> index 77d1177..12c27b6 100644
> --- a/src/android/jpeg/exif.h
> +++ b/src/android/jpeg/exif.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>  /*
>   * Copyright (C) 2020, Google Inc.
>   *

Patch
diff mbox series

diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h
index cf26d67..4483153 100644
--- a/src/android/jpeg/encoder.h
+++ b/src/android/jpeg/encoder.h
@@ -1,4 +1,4 @@ 
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
 /*
  * Copyright (C) 2020, Google Inc.
  *
diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp
index 510613c..a77f5b2 100644
--- a/src/android/jpeg/encoder_libjpeg.cpp
+++ b/src/android/jpeg/encoder_libjpeg.cpp
@@ -1,4 +1,4 @@ 
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
 /*
  * Copyright (C) 2020, Google Inc.
  *
diff --git a/src/android/jpeg/encoder_libjpeg.h b/src/android/jpeg/encoder_libjpeg.h
index 1e8df05..934caef 100644
--- a/src/android/jpeg/encoder_libjpeg.h
+++ b/src/android/jpeg/encoder_libjpeg.h
@@ -1,4 +1,4 @@ 
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
 /*
  * Copyright (C) 2020, Google Inc.
  *
diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp
index e4a116d..d21534a 100644
--- a/src/android/jpeg/exif.cpp
+++ b/src/android/jpeg/exif.cpp
@@ -1,4 +1,4 @@ 
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
 /*
  * Copyright (C) 2020, Google Inc.
  *
diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h
index 77d1177..12c27b6 100644
--- a/src/android/jpeg/exif.h
+++ b/src/android/jpeg/exif.h
@@ -1,4 +1,4 @@ 
-/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
 /*
  * Copyright (C) 2020, Google Inc.
  *