[libcamera-devel,00/15] CameraStream refactoring
mbox series

Message ID 20201005104649.10812-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • CameraStream refactoring
Related show

Message

Laurent Pinchart Oct. 5, 2020, 10:46 a.m. UTC 
Hello,

I'm sending this on behalf of Jacopo as his ISP decided that
git-send-email should be classified as spam.

(From now on 'I' means Jacopo)

The series takes what was sent as 'Internal buffers support' but as the
need for refactoring CameraStream has become more and more pressing, I
decided to bite the bullet and rebase internal buffers support on top of
a rework of CameraStream which now lives in its own .cpp and .h files.

The rework is not only about moving code but also to refactor the class
to make clear the association of an Android camera3_stream_t and the
associated libcamera::StreamConfiguration. There's a bit of churn in the
series, I'm aware of that, alternating new features with refactoring. I
hope it's not confusing.

On top of CameraStream rework, internal buffer allocation and handling
has been moved to the CameraStream class.

Test results are in line with the ones obtained with the last iteration
of the 'Internal buffers' series.

Jacopo Mondi (15):
  android: camera_stream: Break out CameraStream
  android: camera_stream: Add CameraStream::Type
  android: camera_stream: Delegate Encoder construction
  android: camera_stream: Construct with Android stream
  android: camera_device: Move processing to CameraStream
  android: camera_stream: Retrieve Stream and Configuration
  android: camera_stream: Fetch format and size from configuration
  android: camera_device: Return Camera as shared_ptr
  android: camera_stream: Add FrameBufferAllocator
  android: camera_stream: Allocate FrameBuffers
  android: camera_device: Make CameraStream configuration nicer
  android: camera_stream: Add methods to get/put buffers
  android: camera_device: Use CameraStream buffers
  android: camera_device: Add stream mapping log
  android: camera_device: Clear streams_ at stop time

 src/android/camera_device.cpp      | 190 ++++++++++++-----------------
 src/android/camera_device.h        |  30 ++---
 src/android/camera_hal_manager.cpp |   2 +-
 src/android/camera_stream.cpp      | 168 +++++++++++++++++++++++++
 src/android/camera_stream.h        | 152 +++++++++++++++++++++++
 src/android/meson.build            |   1 +
 6 files changed, 411 insertions(+), 132 deletions(-)
 create mode 100644 src/android/camera_stream.cpp
 create mode 100644 src/android/camera_stream.h