[libcamera-devel,v2,0/4] Unify utils locations
mbox series

Message ID 20200923143949.310439-1-kieran.bingham@ideasonboard.com
Headers show
Series
  • Unify utils locations
Related show

Message

Kieran Bingham Sept. 23, 2020, 2:39 p.m. UTC
Various utilities are scattered across the source trees, and are
declared as GPLv2.

Update the meson build to process the utils subdirectory first, giving
us a location where we can define our utilities in a common location.

Then move key generator scripts to the utils directory.
The ipa_gen_priv_key custom target command is renamed to be in keeping
with the other generator commands.

The scripts which handle module signing upon installation are not
handled in this series, as they currently expect to be run from their
current location, and external build systems may be currently
referencing from their current location too.

Later work will aim to tackle the module-signing scripts, moving those
will affect external users.

Also of interest is the definition of the gen-version command used by
the vcs_tag ... but the vcs tag function does not accept a 'files()'
list as it's command parameter, so it's not (yet) suitable to move that
variable declaration to utils/meson.build which had aimed to do.

Kieran Bingham (4):
  meson: Process utils first
  libcamera: Move Header generation utilities to utils
  src: meson: Rename ipa_gen_priv_key to gen_ipa_priv_key
  libcamera: ipa: Move key generation to utils

 include/libcamera/meson.build               | 6 ------
 meson.build                                 | 4 +++-
 src/libcamera/meson.build                   | 3 ---
 src/meson.build                             | 3 +--
 {src/libcamera => utils}/gen-controls.py    | 0
 {include/libcamera => utils}/gen-formats.py | 0
 {include/libcamera => utils}/gen-header.sh  | 0
 {src/ipa => utils}/gen-ipa-priv-key.sh      | 0
 {src/libcamera => utils}/gen-ipa-pub-key.py | 0
 utils/meson.build                           | 9 +++++++++
 10 files changed, 13 insertions(+), 12 deletions(-)
 rename {src/libcamera => utils}/gen-controls.py (100%)
 rename {include/libcamera => utils}/gen-formats.py (100%)
 rename {include/libcamera => utils}/gen-header.sh (100%)
 rename {src/ipa => utils}/gen-ipa-priv-key.sh (100%)
 rename {src/libcamera => utils}/gen-ipa-pub-key.py (100%)

Comments

Paul Elder Sept. 24, 2020, 7:44 a.m. UTC | #1
Hi Kieran,

On Wed, Sep 23, 2020 at 03:39:45PM +0100, Kieran Bingham wrote:
> Various utilities are scattered across the source trees, and are
> declared as GPLv2.
> 
> Update the meson build to process the utils subdirectory first, giving
> us a location where we can define our utilities in a common location.
> 
> Then move key generator scripts to the utils directory.
> The ipa_gen_priv_key custom target command is renamed to be in keeping
> with the other generator commands.
> 
> The scripts which handle module signing upon installation are not
> handled in this series, as they currently expect to be run from their
> current location, and external build systems may be currently
> referencing from their current location too.
> 
> Later work will aim to tackle the module-signing scripts, moving those
> will affect external users.
> 
> Also of interest is the definition of the gen-version command used by
> the vcs_tag ... but the vcs tag function does not accept a 'files()'
> list as it's command parameter, so it's not (yet) suitable to move that
> variable declaration to utils/meson.build which had aimed to do.
> 
> Kieran Bingham (4):
>   meson: Process utils first
>   libcamera: Move Header generation utilities to utils
>   src: meson: Rename ipa_gen_priv_key to gen_ipa_priv_key
>   libcamera: ipa: Move key generation to utils

For all patches in this series:

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

>  include/libcamera/meson.build               | 6 ------
>  meson.build                                 | 4 +++-
>  src/libcamera/meson.build                   | 3 ---
>  src/meson.build                             | 3 +--
>  {src/libcamera => utils}/gen-controls.py    | 0
>  {include/libcamera => utils}/gen-formats.py | 0
>  {include/libcamera => utils}/gen-header.sh  | 0
>  {src/ipa => utils}/gen-ipa-priv-key.sh      | 0
>  {src/libcamera => utils}/gen-ipa-pub-key.py | 0
>  utils/meson.build                           | 9 +++++++++
>  10 files changed, 13 insertions(+), 12 deletions(-)
>  rename {src/libcamera => utils}/gen-controls.py (100%)
>  rename {include/libcamera => utils}/gen-formats.py (100%)
>  rename {include/libcamera => utils}/gen-header.sh (100%)
>  rename {src/ipa => utils}/gen-ipa-priv-key.sh (100%)
>  rename {src/libcamera => utils}/gen-ipa-pub-key.py (100%)
> 
> -- 
> 2.25.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel