[libcamera-devel,v3,00/11] android: camera_device: Fix JPEG/RAW sizes
mbox series

Message ID 20200908134142.27470-1-jacopo@jmondi.org
Headers show
Series
  • android: camera_device: Fix JPEG/RAW sizes
Related show

Message

Jacopo Mondi Sept. 8, 2020, 1:41 p.m. UTC 
This v3 takes into account comments from Laurent and Hiro.

To re-cap the goal of the series is:
Patches 01->05:
- Claim support for JPEG sizes based on the supported YCbCr_888 sizes.
- Enumerate the RAW sizes

Patches 06->12
The goal is to make CameraStream a class which provides a read-only interface
and enforce the creation of CameraStream instances only when all the requested
information (size, format and associated libcamera::StreamConfiguration index)
are available. In the hope this paves ahead to ease introducing more HAL-only
streams by making the CameraStream class the intermediate representation of an
Android stream mapped to a libcamera stream.

Notabled changes:
v2->v3:
- Drop return from CameraConfiguration::addConfig()
- Make encoder * a unique_ptr in CameraStream
- Avoid a few loops and flags as suggested by Laurent and Hiro
- Improve debug output

Thanks
  j

Jacopo Mondi (11):
  android: camera_device: Refuse unsupported formats
  android: camera_device: Generate JPEG sizes
  android: camera_device: Add debug to stream initialization
  android: camera_device: Break out size calculation
  android: camera_device: Generate RAW resolutions
  android: camera_device: Get rid of stream counter
  android: camera_device: Use camera3 stream format
  android: camera_device: Use Android format
  android: camera_device: Rework CameraStream handling
  android: camera_device: Set Encoder at construction
  android: camera_device: Make CameraStream a class

 src/android/camera_device.cpp | 228 +++++++++++++++++++++-------------
 src/android/camera_device.h   |  31 +++--
 2 files changed, 167 insertions(+), 92 deletions(-)

--
2.28.0